Skip to content

Fix system profile behavior #3085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix system profile behavior #3085

wants to merge 1 commit into from

Conversation

mkolegan
Copy link

@mkolegan mkolegan commented Oct 7, 2025 •
edited
Loading

System profile was not read from xml because the logic fallbacks to realData.

In addition to PROFILE_USER and built-in resource-based profiles we need to check PROFILE_SYSTEM

Fix system profile behavior
e2c306c 
System profile was not read from xml because the logic fallback to realData getProfileResId() was returning 0 in that case.

In addition to PROFILE_USER and built-in resource-based profiles  we need to check PROFILE_SYSTEM
@mkolegan mkolegan mentioned this pull request Oct 7, 2025
Open
@mar-v-in mar-v-in added this to the 0.3.11 milestone Oct 13, 2025
@ale5000-git
Copy link
Member

@mar-v-in
I wonder, could we put these checks directly inside getProfileResId, so the caller doesn't have to care?
To avoid future problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.3.11

Development

Successfully merging this pull request may close these issues.

3 participants

@mkolegan @ale5000-git @mar-v-in