Fix readdirpromise #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpeters5392
commented
Jan 1, 2019
jpeters5392
commented
- readdirPromise was emitting the end event prior to the promise resolving so the emitted list of files was always going to be an empty array
- Files excluded by middleware were still getting included in the resolved promise's value, so there is now a filter step prior to resolving that filters out excluded values
- fixed naming of some tests since it seemed like there were some copy/paste values
added 2 commits
January 1, 2019 14:14
* it was emitting the end event prior to the promise completing so the emitted files was an empty array * excluded files were still getting returned in the resolved promise's value, so they are now filtered out prior to completing the promise
…rays prior to filtering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.