Skip to content

Conversation

@epszaw
Copy link

@epszaw epszaw commented Feb 22, 2021

Description

This PR adds .matchingPatterns methods, which returns matched patterns. It's very useful, when you need to determine required patterns by given strings and then use them.

To help the project's maintainers and community to quickly understand the nature of your pull requeset, please create a description that incorporates the following elements:

This PR doesn't contain any breaking changes.

I didn't add support for negative lookup, because I can't imaging use-cases for them. But, if you think, that them also should be implemented – let me know.

New Feature

  • If this is a big feature with breaking changes, consider opening an issue to discuss first. This is completely up to you, but please keep in mind that your pr might not be accepted.
  • Run unit tests to ensure all existing tests are still passing
  • Add new passing unit tests to cover the code introduced by your pr
  • Update the readme (see readme advice)
  • Add your info to the contributors array in package.json!

@epszaw epszaw changed the title Matched patterns method matchingPatterns method Feb 23, 2021
@epszaw
Copy link
Author

epszaw commented Mar 4, 2021

@jonschlinkert can someone make review of these changes? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant