Skip to content

[Designer] Update data binding #8940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −2
Open

[Designer] Update data binding #8940

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8b1092
WIP: update qualified name
anna-dingler Jun 21, 2024
51228f5
Use path[i]
anna-dingler Jun 21, 2024
e696335
Merge branch 'main' into anna/fixDataBind
anna-dingler Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions source/nodejs/adaptivecards-designer/src/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,9 +302,17 @@ export class FieldDefinition {
let forceIndexerSyntax: boolean = false;

for (let i = path.length - 1; i >= 0; i--) {
let qualifiedName = path[i].qualifiedName(false)
let qualifiedName = path[i].qualifiedName(false);

if (shouldUseIndexerSyntax(qualifiedName) || forceIndexerSyntax) {
let modifiedName = qualifiedName;

// If we include `[0]` in the qualified name while determining if we should use indexer syntax,
// We could incorrectly wrap the name in []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add example string?

if (path[i].dataType instanceof ArrayData && qualifiedName.endsWith("[0]")) {
modifiedName = qualifiedName.substring(0, qualifiedName.length - 3);
}

if (shouldUseIndexerSyntax(modifiedName) || forceIndexerSyntax) {
qualifiedName = "['" + qualifiedName + "']";

forceIndexerSyntax = true;
Expand Down