-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[WIP] Chat launcher experience #5615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
compulim
wants to merge
23
commits into
main
Choose a base branch
from
feat-chat-launcher
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+3,018
−522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
Design
Build scripts changes
npm run build:pre
will rewritepackage.json/localDependencies
andpackage.json/scripts/start
scripts/start
is computed and overwrite automatically 🥳package.json
, we can see what it will run againstnpm run start
actually runnpm run build:run
once and exit, notsup --watch
tsup.config.ts
🥳inotifywatch
to watch for changesnpm run build
themselves first 🥳package.json
, right after ESM is builttsup --onSuccess
will be triggered twice, one for CJS and one for ESMdtsroll
is inbuild:post:dtsroll
, because we don't need it in development environmentprebuild
/postbuild
... because I want to keep--ignore-scripts
enabled/scripts/npm/bump-dev.sh
, etc...Tried
nodemon
andnode --watch
, both doesn't work as good asinotifywait
. Especially around how it queue up changes while the build is ongoing.inotifywait
in shell script is most flexible option.Specific Changes
-
CHANGELOG.md
Review Checklist
z-index
)package.json
andpackage-lock.json
reviewed