fix: updates to GitHub Actions workflows to improve security and streamline triggers #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roopan-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates GitHub Actions workflows to improve security and streamline trigger conditions.
- Updated Create-Release.yml to use secrets.GITHUB_TOKEN for secure token management.
- Removed push event triggers in azure-dev-validation.yml to allow only manual (workflow_dispatch) triggering.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/azure-dev-validation.yml | Removed push triggers for dev and main branches to rely solely on manual triggering. |
| .github/workflows/Create-Release.yml | Updated environment variable to use secrets.GITHUB_TOKEN for enhanced security. |
Vinay-Microsoft
approved these changes
Apr 24, 2025
Vinay-Microsoft
approved these changes
Apr 24, 2025
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Security improvement:
.github/workflows/Create-Release.yml: Updated theGITHUB_TOKENenvironment variable to usesecrets.GITHUB_TOKENinstead ofsecrets.TOKEN, ensuring alignment with standard GitHub practices for secure token management.Trigger condition simplification:
.github/workflows/azure-dev-validation.yml: Removed thepushevent trigger for thedevandmainbranches, leaving only theworkflow_dispatchtrigger to allow manual execution of the Azure Template Validation workflow.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information