fix: minor fixes in setup_env.sh, create_sql_user_role.sh, readme #519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes updates to improve script compatibility, streamline dependencies, and adjust deployment configurations. The most important changes involve enhancing script execution logic, removing unused dependencies, and updating deployment parameters.
Script Compatibility Improvements:
.devcontainer/setup_env.sh: Updated thechmodcommand to usesudofor better compatibility across environments. Removed installation steps for Azure Functions Core Tools, as it is no longer required. [1] [2]infra/scripts/run_create_index_scripts.sh: Added logic to dynamically determine the correct Python command (python3orpython) and updated virtual environment creation to use the determined command.infra/scripts/add_user_scripts/create_sql_user_and_role.sh: Enhanced logic to fetch the signed-in user's email, falling back touserPrincipalNameif the email is unavailable.Dependency Streamlining:
infra/scripts/index_scripts/create_sql_tables.pyandinfra/scripts/index_scripts/requirements.txt: Removed the unusedpymssqllibrary to simplify dependencies. [1] [2]Deployment Configuration Adjustments:
.github/workflows/CAdeploy.yml: Replaced thecosmosLocationparameter withAZURE_ENV_OPENAI_LOCATIONin the Azure deployment command for more accurate configuration.Documentation Update:
README.md: Updated the "Open in Codespaces" link to remove theref=devquery parameter for a cleaner URL.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information