Skip to content

Conversation

@Harsh-Microsoft
Copy link
Contributor

Purpose

This pull request includes updates to improve script compatibility, streamline dependencies, and adjust deployment configurations. The most important changes involve enhancing script execution logic, removing unused dependencies, and updating deployment parameters.

Script Compatibility Improvements:

Dependency Streamlining:

  • infra/scripts/index_scripts/create_sql_tables.py and infra/scripts/index_scripts/requirements.txt: Removed the unused pymssql library to simplify dependencies. [1] [2]

Deployment Configuration Adjustments:

  • .github/workflows/CAdeploy.yml: Replaced the cosmosLocation parameter with AZURE_ENV_OPENAI_LOCATION in the Azure deployment command for more accurate configuration.

Documentation Update:

  • README.md: Updated the "Open in Codespaces" link to remove the ref=dev query parameter for a cleaner URL.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

…ed azure function tools; improve user email retrieval in create_sql_user_and_role.sh; clean up requirements
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request makes minor fixes to scripts and configuration files to improve deployment compatibility and streamline dependencies.

  • Removed an unused dependency (pymssql) from the SQL table creation script.
  • Updated the Codespaces URL in the README for a cleaner link.
  • Replaced the cosmosLocation parameter with AZURE_ENV_OPENAI_LOCATION in the deployment workflow.

Reviewed Changes

Copilot reviewed 4 out of 8 changed files in this pull request and generated no comments.

File Description
infra/scripts/index_scripts/create_sql_tables.py Removed unused pymssql import to streamline dependencies.
README.md Updated the Codespaces URL link by removing the ref=dev query parameter.
.github/workflows/CAdeploy.yml Changed deployment parameter; verify if dropping solutionPrefix was intentional.
Files not reviewed (4)
  • .devcontainer/setup_env.sh: Language not supported
  • infra/scripts/add_user_scripts/create_sql_user_and_role.sh: Language not supported
  • infra/scripts/index_scripts/requirements.txt: Language not supported
  • infra/scripts/run_create_index_scripts.sh: Language not supported
Comments suppressed due to low confidence (1)

.github/workflows/CAdeploy.yml:118

  • The updated deployment command no longer includes the solutionPrefix parameter. Please confirm if the removal of solutionPrefix is intentional as this might affect the deployment configuration.
--parameters AZURE_ENV_OPENAI_LOCATION=${{ env.AZURE_LOCATION }}

@Roopan-Microsoft Roopan-Microsoft merged commit 4a1e1b5 into main Apr 25, 2025
8 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants