fix: readme updated quota, python version recommendation, fabric deployment guide #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed azure function tools; improve user email retrieval in create_sql_user_and_role.sh; clean up requirements
…k_params.sh; adjust Deployment Guide token capacity recommendation and Python version range
Harsh-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the Deployment Guide documentation to reflect an increased quota recommendation for the GPT-4o-mini model and clarifies the supported Python versions for deployment.
- Updated the quota recommendation from 100k tokens to 150k tokens.
- Changed the supported Python version indicator from "3.9+" to "3.9 to 3.11".
Files not reviewed (1)
- .devcontainer/setup_env.sh: Language not supported
Harsh-Microsoft
changed the title
…fy default regions in quota_check_params.sh
Roopan-Microsoft
approved these changes
Apr 25, 2025
|
🎉 This PR is included in version 1.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes updates to scripts, documentation, and deployment configurations to improve clarity, consistency, and functionality. Key changes include updates to quota recommendations, region restrictions, and deployment parameters, as well as adjustments to documentation for better usability.
Deployment Configuration Updates:
infra/main.bicepto remove unsupported regions (norwayeast,southindia).DEFAULT_REGIONSlist ininfra/scripts/quota_check_params.shto align with the updated allowed regions.gpt-4omodel option from thegptModelNameparameter ininfra/main.bicepto simplify deployment options.Documentation Improvements:
docs/DeploymentGuide.mdanddocs/quota_check.mdto suggest increasing GPT-4o-mini capacity to 150k tokens for optimal performance. [1] [2]docs/DeploymentGuide.mdto specify compatibility with versions 3.9 to 3.11.docs/FabricDeployment.mdby adding details about report usage and filtering options, while commenting out deprecated steps for Power BI configuration. [1] [2]Script Enhancements:
quota_check_params.shin.devcontainer/setup_env.shto ensure proper script functionality.Workflow Adjustments:
.github/workflows/CAdeploy.ymlby changingAZURE_ENV_OPENAI_LOCATIONtoAzureOpenAILocationfor consistency.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information