fix: [Research Assistant] - PopUp not disappear after displaying message #667
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request improves error handling and robustness in the document section generation workflow for the Draft Documents feature. The main changes ensure that unexpected backend responses (such as non-JSON or error status codes) are correctly handled and surfaced to the user, preventing UI inconsistencies and improving debugging. The changes also streamline the asynchronous logic for generating section content and ensure overlays are closed reliably.
Error handling and backend response robustness:
documentSectionGenerate
to log HTTP errors with status and status text for failed requests.ResearchTopicCard
, added explicit checks for missing or rejected backend responses, with clear error messages and UI feedback for bad requests or non-JSON responses.ResearchTopicCard
andCard
, added try/catch logic to handle unexpected non-JSON responses, ensuring that errors do not hide previous failures and that the UI remains responsive.UI and workflow improvements:
ResearchTopicCard
, reset error state at the start of a generation run and ensured overlays are always closed after generation, regardless of success or failure.Card
, moved loading state reset to afinally
block to guarantee UI updates after section generation attempts, even if errors occur.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information