Skip to content

Conversation

Harsh-Microsoft
Copy link
Contributor

Purpose

This pull request updates the infrastructure templates to improve support for deploying with either new or existing AI Foundry projects, and adds outputs to expose the System Assigned Managed Identity Principal Id. It also updates the way container image tags are specified and referenced. The most important changes are as follows:

AI Foundry Project Integration Improvements:

  • Enhanced support for existing AI Foundry projects by extracting subscription ID, resource group, and service name from the existingFoundryProjectResourceId parameter, and referencing the existing project resource directly in the deployment. [1] [2] [3]
  • Added aiprojectSystemAssignedMIPrincipalId as an output and parameter in multiple locations, ensuring the System Assigned Managed Identity Principal Id is available for both new and existing AI Foundry projects. [1] [2] [3] [4] [5] [6]

Container Image Tag Parameterization:

  • Renamed the container image tag parameter from containerImageTag to imageTag and updated its default value to a new version string; updated all references accordingly in both the Bicep and generated JSON templates. [1] [2] [3]

Role Assignment and Resource Reference Changes:

  • Removed explicit role assignment resources for Search Index Data Reader and Search Service Contributor when using new AI projects; instead, for existing projects, the template now references the existing project resource directly, simplifying the deployment logic.

Template Maintenance:

  • Updated various template hash values and generator metadata as a result of the above changes and regeneration of the ARM template from Bicep. [1] [2] [3] [4] [5] [6]

These updates make the infrastructure templates more flexible, maintainable, and better aligned with current deployment needs.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors infrastructure templates to improve container image tag handling and enhance AI Foundry project integration. It renames the container image tag parameter to be more consistent and updates templates to better support both new and existing AI Foundry projects.

Key changes:

  • Renamed containerImageTag parameter to imageTag with updated version string
  • Enhanced existing AI Foundry project support by extracting resource details and adding direct project references
  • Added aiprojectSystemAssignedMIPrincipalId output for both new and existing AI projects

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
infra/main.json Generated ARM template with updated parameter names, AI project handling logic, and template metadata
infra/main.bicep Source Bicep template with renamed imageTag parameter and updated reference

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Roopan-Microsoft Roopan-Microsoft merged commit a1cdb97 into main Sep 22, 2025
8 checks passed
Copy link

🎉 This PR is included in version 1.9.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants