-
Notifications
You must be signed in to change notification settings - Fork 155
feat: Merging the AVM Waf changes into byoc-researcher #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in parameters in main.parameters.json; set publicNetworkAccess to 'Enabled' in main.bicep for draft flow deployment
…ccess based on private networking configuration
… Bicep and JSON templates
…frastructure deployment, including AI services, app services, key vault, managed identity, storage account, and deployment scripts.
…ocus on deployment options
…ction steps and troubleshooting tips; update link reference in Deployment Guide for clarity.
Roopan-Microsoft
approved these changes
Sep 29, 2025
Prajwal-Microsoft
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Infrastructure Modernization:
deploy_app_service.bicep
. Legacy resource definitions are commented out, and new AVM modules (webServerFarm
,applicationInsights
) are used instead. [1] [2]deploy_app_service.bicep
to reference new AVM modules instead of legacy resources, ensuring correct deployment order.Parameter and Resource Definition Improvements:
deploy_app_service.bicep
anddeploy_index_scripts.bicep
, improving usability and reducing ambiguity during deployment. Some unused parameters are commented out for clarity. [1] [2]azure.yaml
manifest to specify template metadata and required Azure Developer CLI (azd
) version, supporting standardized deployment workflows.main.parameters.json
file for parameterizing infrastructure deployments, enabling environment-based configuration and easier automation.Documentation Enhancements:
README.md
documenting step-by-step instructions for deploying with Azure Developer CLI (azd
), making the deployment process more accessible for users.Other Changes:
main.bicep
file, indicating a shift to the new modular and parameterized infrastructure approach.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information