fix: CI pipeline issue fix #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CI Pipeline fix for Client Advisor * added tags in CAdeploy.yml file * add my feature branch * tags changes updated in CAdeploy.yml file * added template name condition based * removed my feature branch from pipeline * Additional Troubleshooting steps
… bice… (#678) * Remove createdby from pipeline and add change Createdby logic in bicep file * Add 'createdBy' parameter to Azure deployment * Add 'createdBy' parameter for tagging
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
feat: Create Separate User Assigned Identity for SQL DB with Specified Access
…emoved the unsued params (#690) * fix: Dev to main (#681) * fix: added tags in CAdeploy.yml file (#675) * CI Pipeline fix for Client Advisor * added tags in CAdeploy.yml file * add my feature branch * tags changes updated in CAdeploy.yml file * added template name condition based * removed my feature branch from pipeline * Additional Troubleshooting steps * fix: Remove createdby from pipeline and add change Createdby logic in bice… (#678) * Remove createdby from pipeline and add change Createdby logic in bicep file * Add 'createdBy' parameter to Azure deployment * Add 'createdBy' parameter for tagging * added new 'type' tag (#682) * Update docs/TroubleShootingSteps.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update GitHub Issues link in troubleshooting steps --------- Co-authored-by: VishalS-Microsoft <v-vishshinde@microsoft.com> Co-authored-by: Harsh-Microsoft <v-hbangera@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: Removed commented params * Update README and azure.yml for minimum azd version 1.18.0 --------- Co-authored-by: NirajC-Microsoft <v-nirajcha@microsoft.com> Co-authored-by: VishalS-Microsoft <v-vishshinde@microsoft.com> Co-authored-by: Harsh-Microsoft <v-hbangera@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Prajwal D C <v-dcprajwal@microsoft.com>
Disable the use of Dev Container for Azure template validation.
fix: Cross subscription issue while running post deployments scrip
* ci: Update environment variable assignments for SQL client IDs and names in deploy wf * Remove redundant branch from deployment triggers
Prajwal-Microsoft
requested review from
Avijit-Microsoft and
Roopan-Microsoft
as code owners
Prajwal-Microsoft
requested review from
Vinay-Microsoft and
aniaroramsft
as code owners
feat: Down merge from dev
Roopan-Microsoft
approved these changes
Oct 3, 2025
Roopan-Microsoft
approved these changes
Oct 3, 2025
Vinay-Microsoft
approved these changes
Oct 3, 2025
|
🎉 This PR is included in version 1.9.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request makes a minor update to the workflow configuration in
.github/workflows/CAdeploy.ymlto ensure the correct managed identity values are used for SQL resources instead of web application resources.CLIENT_IDandCLIENT_NAMEenvironment variables to use SQL managed identity values (managedidentitY_SQL_CLIENTIDandmanagedidentitY_SQL_NAME) instead of the previous web app managed identity fields.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information