fix: Fix process_sample_data.sh #705
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces improvements to the deployment and post-deployment process for the Azure infrastructure, focusing on enhanced guidance, script usability, and resource output clarity. The main changes include updating deployment scripts and documentation to consistently require the resource group name as an argument, expanding the sample data processing script to retrieve additional managed identity and database information, and exposing the Azure subscription ID as an output in the Bicep template.
Deployment and Script Usability Improvements
azure.yaml
to explicitly include the resource group name as an argument when runningprocess_sample_data.sh
, improving clarity and reducing user error. [1] [2]docs/AVMPostDeploymentGuide.md
to match the updated script invocation syntax, ensuring users run the script correctly.Infrastructure Output Enhancements
infra/main.bicep
, making it available for downstream scripts and documentation.Sample Data Script Expansion
infra/scripts/process_sample_data.sh
to automatically retrieve and display additional deployment outputs, including managed identity client IDs and display names for both the web app and SQL database, as well as the SQL database name.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information