fix: Dev to main #706
Merged
fix: Dev to main #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: post deployment script changes
fix: Fix process_sample_data.sh
NirajC-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Roopan-Microsoft
approved these changes
Oct 13, 2025
fix: Updated the networking module
Roopan-Microsoft
approved these changes
Oct 13, 2025
|
🎉 This PR is included in version 1.9.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several important improvements to the post-deployment workflow and infrastructure automation for the Build Your Own Copilot Accelerator. The main changes focus on streamlining the sample data import process, enhancing documentation for post-deployment steps, and improving resource tagging and output management in the deployment scripts and templates.
Post-Deployment Workflow & Documentation Enhancements:
AVMPostDeploymentGuide.mdto document post-deployment steps, including repository cloning, sample data import, authentication provider setup, and resource cleanup guidance.Sample Data Import & Automation Improvements:
process_sample_data.sh) to accept only the resource group name as an argument and dynamically fetch all other required resource names and IDs from deployment outputs, with interactive prompts if the deployment does not exist. This makes the import process more robust and user-friendly. [1] [2]azure.yamlto pass the resource group name to the sample data script, ensuring correct parameterization and alignment with the new script logic. [1] [2]Infrastructure Template & Output Improvements:
infra/main.bicep)infra/main.bicepto provide the Azure Subscription ID instead of the client ID, improving clarity and consistency for downstream scripts and users.Miscellaneous Script Improvements:
checkquota.shto set the insufficient quota flag when quota information is missing, ensuring more reliable quota checks.These updates collectively streamline the deployment and post-deployment experience, making it easier for users to get started and manage their resources effectively.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information