C++ entry points #7552
Merged
C++ entry points #7552
+3
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the C ABI requirement for enclave entry points by transitioning from extern "C" linkage to C++ namespace-scoped functions. The entry points enclave_create_node and enclave_run are now properly scoped within the ccf namespace, allowing for C++ linkage throughout the codebase.
- Entry point functions moved from
extern "C"tonamespace ccfin both declaration and implementation - Linker flags for undefined symbols removed (no longer needed with C++ linkage)
- Library link order corrected to ensure proper symbol resolution
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/enclave/main.cpp | Changed entry point implementations from extern "C" to namespace ccf |
| src/enclave/entry_points.h | Changed entry point declarations from extern "C" to namespace ccf |
| cmake/ccf_app.cmake | Removed --undefined linker flags for entry points and corrected library link order |
eddyashton
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need to use the C ABI here.