LoadingGroups: Remove recursions from function #25632
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the logic in the
isSnapshotFetchRequiredForLoadingGroupId
function to improve its efficiency and readability. Instead of using recursion to traverse the snapshot tree, it now uses an explicit stack-based approach for iterative traversal. This change makes the code easier to follow and can help avoid potential stack overflow issues with deeply nested trees.Snapshot tree traversal improvements:
trees
) to process eachISnapshotTree
node, making the function more efficient and readable.groupId
are pushed onto the stack for further evaluation, maintaining the correct logic for determining if a snapshot fetch is required.