Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions common/build/eslint-config-fluid/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,6 @@ module.exports = {
plugins: ["import-x", "unicorn"],
reportUnusedDisableDirectives: true,
rules: {
// These rules were deprecated, then removed in `@typescript-eslint/eslint-plugin` v8.
// They are replaced by a set of more specific rules, which have been enabled in the list below.
// These explicit disable will need to be removed when this package is updated to v8+ of the plugin.
"@typescript-eslint/ban-types": "off",
"@typescript-eslint/no-empty-interface": "off",

// Please keep entries alphabetized within a group

// #region Fluid Custom Rules
Expand Down Expand Up @@ -111,7 +105,7 @@ module.exports = {
},
],
"@typescript-eslint/no-this-alias": "error",
"@typescript-eslint/no-throw-literal": "error",
"@typescript-eslint/only-throw-error": "error",
"@typescript-eslint/no-unused-expressions": "error",
"@typescript-eslint/no-unused-vars": "off",
"@typescript-eslint/no-unnecessary-qualifier": "error",
Expand Down Expand Up @@ -158,6 +152,17 @@ module.exports = {
],
"@typescript-eslint/unified-signatures": "error",
"@typescript-eslint/no-wrapper-object-types": "error",
"@typescript-eslint/no-restricted-types": [
"error",
{
types: {
null: {
message: "Avoid using null; prefer undefined instead.",
fixWith: "undefined",
},
},
},
],

// #endregion

Expand Down
9 changes: 6 additions & 3 deletions common/build/eslint-config-fluid/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
"@rushstack/eslint-patch": "~1.12.0",
"@rushstack/eslint-plugin": "~0.19.0",
"@rushstack/eslint-plugin-security": "~0.11.0",
"@typescript-eslint/eslint-plugin": "~7.18.0",
"@typescript-eslint/parser": "~7.18.0",
"@typescript-eslint/eslint-plugin": "~8.18.2",
"@typescript-eslint/parser": "~8.18.2",
"eslint-config-biome": "~2.1.3",
"eslint-config-prettier": "~10.1.8",
"eslint-import-resolver-typescript": "~4.4.4",
Expand Down Expand Up @@ -65,6 +65,9 @@
],
"overrides": {
"mocha>serialize-javascript@6.0.0": "^6.0.2"
}
},
"onlyBuiltDependencies": [
"unrs-resolver"
]
}
}
144 changes: 100 additions & 44 deletions common/build/eslint-config-fluid/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading