test(client-container-loader): respect exactOptionalPropertyTypes #25668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `AbsentProperty` token to mark absent properties under Proxy rather than `undefined` to support exactOptionalPropertyTypes=true builds. Additionally add `has` checks within `failSometimeProxy` to detect new properties whose existence is checked that way. Remove unused `undefined` unions in `MockContainer` that violate `IContainer` specification under exactOptionalPropertyTypes=true.
github-actions
bot
added
area: loader
There was a problem hiding this comment.
Pull Request Overview
This PR updates the client-container-loader test suite to support TypeScript's exactOptionalPropertyTypes compiler option by introducing an AbsentProperty token to explicitly mark absent properties in test proxies instead of using undefined.
- Enables
exactOptionalPropertyTypesin the TypeScript configuration for improved type safety - Introduces
AbsentPropertysymbol andPartialOrAbsenttype for explicit property absence handling - Updates test proxies to use
AbsentPropertyinstead ofundefinedfor optional properties
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
packages/loader/container-loader/src/test/tsconfig.json |
Removes the exactOptionalPropertyTypes: false override to enable strict optional property type checking |
packages/loader/container-loader/src/test/failProxy.ts |
Adds AbsentProperty symbol, PartialOrAbsent type, and implements has trap for proper property existence handling |
packages/loader/container-loader/src/test/testProxies.ts |
Updates proxy creation to use AbsentProperty for optional properties |
packages/loader/container-loader/src/test/loader.spec.ts |
Updates proxy initialization to use AbsentProperty |
packages/loader/container-loader/src/test/container.spec.ts |
Removes unnecessary undefined unions from MockContainer properties |
packages/loader/container-loader/src/test/attachment.spec.ts |
Updates proxy creation and property handling to use new AbsentProperty pattern |
Handle AbsentProperty in createProxyWithFailDefault. Use Reflect.get and only one read in failSometimeProxy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
AbsentPropertytoken to mark absent properties under Proxy rather thanundefinedto support exactOptionalPropertyTypes=true builds. Additionally addhaschecks withinfailSometimeProxyto detect new properties whose existence is checked that way.Remove unused
undefinedunions inMockContainerthat violateIContainerspecification under exactOptionalPropertyTypes=true.