Skip to content

fix: Reduce Excessive Developer Console Logging #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev-v3
Choose a base branch
from
Open

fix: Reduce Excessive Developer Console Logging #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/frontend/src/api/apiService.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ export class APIService {
if (!data) {
throw new Error(`Plan with ID ${planId} not found`);
}
console.log('Fetched plan by ID:', data);
const results = {
plan: data.plan as Plan,
messages: data.messages as AgentMessageBE[],
Expand Down Expand Up @@ -194,7 +193,6 @@ export class APIService {
const requestKey = `approve-plan-${planApprovalData.m_plan_id}`;

return this._requestTracker.trackRequest(requestKey, async () => {
console.log('📤 Approving plan via v3 API:', planApprovalData);

const response = await apiClient.post(API_ENDPOINTS.PLAN_APPROVAL, planApprovalData);

Expand All @@ -203,8 +201,6 @@ export class APIService {
if (planApprovalData.plan_id) {
this._cache.invalidate(new RegExp(`^plan.*_${planApprovalData.plan_id}`));
}

console.log('✅ Plan approval successful:', response);
return response;
});
}
Expand Down Expand Up @@ -266,11 +262,6 @@ export class APIService {
async sendAgentMessage(data: AgentMessageResponse): Promise<AgentMessage> {
const t0 = performance.now();
const result = await apiClient.post(API_ENDPOINTS.AGENT_MESSAGE, data);
console.log('[agent_message] sent', {
ms: +(performance.now() - t0).toFixed(1),
agent: data.agent,
type: data.agent_type
});
return result;
}
}
Expand Down
3 changes: 0 additions & 3 deletions src/frontend/src/components/common/TeamSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ const TeamSelector: React.FC<TeamSelectorProps> = ({
try {
// If this team was just uploaded, skip the selection API call and go directly to homepage
if (uploadedTeam && uploadedTeam.team_id === tempSelectedTeam.team_id) {
console.log('Uploaded team selected, going directly to homepage:', tempSelectedTeam.name);
onTeamSelect?.(tempSelectedTeam);
setIsOpen(false);
return; // Skip the selectTeam API call
Expand All @@ -129,7 +128,6 @@ const TeamSelector: React.FC<TeamSelectorProps> = ({
const result = await TeamService.selectTeam(tempSelectedTeam.team_id);

if (result.success) {
console.log('Team selected:', result.data);
onTeamSelect?.(tempSelectedTeam);
setIsOpen(false);
} else {
Expand Down Expand Up @@ -566,7 +564,6 @@ const TeamSelector: React.FC<TeamSelectorProps> = ({
placeholder="Search teams..."
value={searchQuery}
onChange={(e: React.ChangeEvent<HTMLInputElement>, data: InputOnChangeData) => {
console.log('Search changed:', data.value);
setSearchQuery(data.value || '');
}}
contentBefore={<Search20Regular />}
Expand Down
1 change: 0 additions & 1 deletion src/frontend/src/components/content/HomeInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ const HomeInput: React.FC<HomeInputProps> = ({
input.trim(),
selectedTeam?.team_id
);
console.log("Plan created:", response);
setInput("");

if (textareaRef.current) {
Expand Down
2 changes: 0 additions & 2 deletions src/frontend/src/components/content/PlanPanelLeft.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ const PlanPanelLeft: React.FC<PlanPanelLefProps> = ({

const loadPlansData = useCallback(async (forceRefresh = false) => {
try {
console.log("Loading plans, forceRefresh:", forceRefresh);
setPlansLoading(true);
setPlansError(null);
const plansData = await apiService.getPlans(undefined, !forceRefresh); // Invert forceRefresh for useCache
Expand Down Expand Up @@ -93,7 +92,6 @@ const PlanPanelLeft: React.FC<PlanPanelLefProps> = ({


useEffect(() => {
console.log("Reload tasks changed:", reloadTasks);
if (reloadTasks) {
loadPlansData(true); // Force refresh when reloadTasks is true
}
Expand Down
2 changes: 0 additions & 2 deletions src/frontend/src/hooks/useTeamSelection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,11 @@ export const useTeamSelection = ({
setError(null);

try {
console.log('Selecting team:', team.name, 'with session ID:', sessionId);

const result = await TeamService.selectTeam(team.team_id);

if (result.success) {
setSelectedTeam(team);
console.log('Team selection successful:', result.data);

// Call success callback
onTeamSelected?.(team, result.data);
Expand Down
14 changes: 0 additions & 14 deletions src/frontend/src/pages/HomePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,10 @@ const HomePage: React.FC = () => {
setIsLoadingTeam(true);

try {
console.log('Initializing team from backend...');
// Call the backend init_team endpoint (takes ~20 seconds)
const initResponse = await TeamService.initializeTeam();

if (initResponse.data?.status === 'Request started successfully' && initResponse.data?.team_id) {
console.log('Team initialization completed:', initResponse.data?.team_id);

// Now fetch the actual team details using the team_id
const teams = await TeamService.getUserTeams();
Expand All @@ -46,16 +44,12 @@ const HomePage: React.FC = () => {
setSelectedTeam(initializedTeam);
TeamService.storageTeam(initializedTeam);

console.log('Team loaded successfully:', initializedTeam.name);
console.log('Team agents:', initializedTeam.agents?.length || 0);

showToast(
`${initializedTeam.name} team initialized successfully with ${initializedTeam.agents?.length || 0} agents`,
"success"
);
} else {
// Fallback: if we can't find the specific team, use HR team or first available
console.log('Specific team not found, using default selection logic');
const hrTeam = teams.find(team => team.name === "Human Resources Team");
const defaultTeam = hrTeam || teams[0];

Expand Down Expand Up @@ -99,15 +93,13 @@ const HomePage: React.FC = () => {
const handleTeamSelect = useCallback(async (team: TeamConfig | null) => {
setSelectedTeam(team);
setReloadLeftList(true);
console.log('handleTeamSelect called with team:', true);
if (team) {

try {
setIsLoadingTeam(true);
const initResponse = await TeamService.initializeTeam(true);

if (initResponse.data?.status === 'Request started successfully' && initResponse.data?.team_id) {
console.log('handleTeamSelect:', initResponse.data?.team_id);

// Now fetch the actual team details using the team_id
const teams = await TeamService.getUserTeams();
Expand All @@ -117,9 +109,6 @@ const HomePage: React.FC = () => {
setSelectedTeam(initializedTeam);
TeamService.storageTeam(initializedTeam);
setReloadLeftList(true)
console.log('Team loaded successfully handleTeamSelect:', initializedTeam.name);
console.log('Team agents handleTeamSelect:', initializedTeam.agents?.length || 0);

showToast(
`${initializedTeam.name} team initialized successfully with ${initializedTeam.agents?.length || 0} agents`,
"success"
Expand Down Expand Up @@ -155,15 +144,12 @@ const HomePage: React.FC = () => {
const handleTeamUpload = useCallback(async () => {
try {
const teams = await TeamService.getUserTeams();
console.log('Teams refreshed after upload:', teams.length);

if (teams.length > 0) {
// Always keep "Human Resources Team" as default, even after new uploads
const hrTeam = teams.find(team => team.name === "Human Resources Team");
const defaultTeam = hrTeam || teams[0];
setSelectedTeam(defaultTeam);
console.log('Default team after upload:', defaultTeam.name);
console.log('Human Resources Team remains default');
showToast(
`Team uploaded successfully! ${defaultTeam.name} remains your default team.`,
"success"
Expand Down
29 changes: 0 additions & 29 deletions src/frontend/src/pages/PlanPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,14 +131,8 @@ const PlanPage: React.FC = () => {

// Persist / forward to backend (fire-and-forget with logging)
const agentMessageResponse = PlanDataService.createAgentMessageResponse(agentMessageData, planData, is_final, streaming_message);
console.log('📤 Persisting agent message:', agentMessageResponse);
const sendPromise = apiService.sendAgentMessage(agentMessageResponse)
.then(saved => {
console.log('[agent_message][persisted]', {
agent: agentMessageData.agent,
type: agentMessageData.agent_type,
ts: agentMessageData.timestamp
});

// If this is a final message, refresh the task list after successful persistence
if (is_final) {
Expand Down Expand Up @@ -219,7 +213,6 @@ const PlanPage: React.FC = () => {
//WebsocketMessageType.PLAN_APPROVAL_REQUEST
useEffect(() => {
const unsubscribe = webSocketService.on(WebsocketMessageType.PLAN_APPROVAL_REQUEST, (approvalRequest: any) => {
console.log('📋 Plan received:', approvalRequest);

let mPlanData: MPlanData | null = null;

Expand All @@ -244,7 +237,6 @@ const PlanPage: React.FC = () => {
}

if (mPlanData) {
console.log('✅ Parsed plan data:', mPlanData);
setPlanApprovalRequest(mPlanData);
setWaitingForPlan(false);
setShowProcessingPlanSpinner(false);
Expand All @@ -260,7 +252,6 @@ const PlanPage: React.FC = () => {
//(WebsocketMessageType.AGENT_MESSAGE_STREAMING
useEffect(() => {
const unsubscribe = webSocketService.on(WebsocketMessageType.AGENT_MESSAGE_STREAMING, (streamingMessage: any) => {
//console.log('📋 Streaming Message', streamingMessage);
// if is final true clear buffer and add final message to agent messages
const line = PlanDataService.simplifyHumanClarification(streamingMessage.data.content);
setShowBufferingText(true);
Expand All @@ -275,8 +266,6 @@ const PlanPage: React.FC = () => {
//WebsocketMessageType.USER_CLARIFICATION_REQUEST
useEffect(() => {
const unsubscribe = webSocketService.on(WebsocketMessageType.USER_CLARIFICATION_REQUEST, (clarificationMessage: any) => {
console.log('📋 Clarification Message', clarificationMessage);
console.log('📋 Current plan data User clarification', planData);
if (!clarificationMessage) {
console.warn('⚠️ clarification message missing data:', clarificationMessage);
return;
Expand All @@ -290,7 +279,6 @@ const PlanPage: React.FC = () => {
content: clarificationMessage.data.question || '',
raw_data: clarificationMessage.data || '',
} as AgentMessageData;
console.log('✅ Parsed clarification message:', agentMessageData);
setClarificationMessage(clarificationMessage.data as ParsedUserClarification | null);
setAgentMessages(prev => [...prev, agentMessageData]);
setShowBufferingText(false);
Expand All @@ -307,7 +295,6 @@ const PlanPage: React.FC = () => {
//WebsocketMessageType.AGENT_TOOL_MESSAGE
useEffect(() => {
const unsubscribe = webSocketService.on(WebsocketMessageType.AGENT_TOOL_MESSAGE, (toolMessage: any) => {
console.log('📋 Tool Message', toolMessage);
// scrollToBottom()

});
Expand All @@ -319,7 +306,6 @@ const PlanPage: React.FC = () => {
//WebsocketMessageType.FINAL_RESULT_MESSAGE
useEffect(() => {
const unsubscribe = webSocketService.on(WebsocketMessageType.FINAL_RESULT_MESSAGE, (finalMessage: any) => {
console.log('📋 Final Result Message', finalMessage);
if (!finalMessage) {

console.warn('⚠️ Final result message missing data:', finalMessage);
Expand All @@ -335,8 +321,6 @@ const PlanPage: React.FC = () => {
raw_data: finalMessage || '',
} as AgentMessageData;


console.log('✅ Parsed final result message:', agentMessageData);
// we ignore the terminated message
if (finalMessage?.data?.status === PlanStatus.COMPLETED) {

Expand Down Expand Up @@ -367,8 +351,6 @@ const PlanPage: React.FC = () => {
//WebsocketMessageType.AGENT_MESSAGE
useEffect(() => {
const unsubscribe = webSocketService.on(WebsocketMessageType.AGENT_MESSAGE, (agentMessage: any) => {
console.log('📋 Agent Message', agentMessage)
console.log('📋 Current plan data', planData);
const agentMessageData = agentMessage.data as AgentMessageData;
if (agentMessageData) {
agentMessageData.content = PlanDataService.simplifyHumanClarification(agentMessageData?.content);
Expand Down Expand Up @@ -399,12 +381,10 @@ const PlanPage: React.FC = () => {
// WebSocket connection with proper error handling and v3 backend compatibility
useEffect(() => {
if (planId && continueWithWebsocketFlow) {
console.log('🔌 Connecting WebSocket:', { planId, continueWithWebsocketFlow });

const connectWebSocket = async () => {
try {
await webSocketService.connect(planId);
console.log('✅ WebSocket connected successfully');
} catch (error) {
console.error('❌ WebSocket connection failed:', error);
// Continue without WebSocket - the app should still work
Expand All @@ -415,25 +395,21 @@ const PlanPage: React.FC = () => {

const handleConnectionChange = (connected: boolean) => {
setWsConnected(connected);
console.log('🔗 WebSocket connection status:', connected);
};

const handleStreamingMessage = (message: StreamMessage) => {
console.log('📨 Received streaming message:', message);
if (message.data && message.data.plan_id) {
setStreamingMessages(prev => [...prev, message.data]);
}
};

const handlePlanApprovalResponse = (message: StreamMessage) => {
console.log('✅ Plan approval response received:', message);
if (message.data && message.data.approved) {
setPlanApproved(true);
}
};

const handlePlanApprovalRequest = (message: StreamMessage) => {
console.log('📥 Plan approval request received:', message);
// This is handled by PlanChat component through its own listener
};

Expand All @@ -448,7 +424,6 @@ const PlanPage: React.FC = () => {
const unsubscribeParsedPlanApprovalRequest = webSocketService.on(WebsocketMessageType.PLAN_APPROVAL_REQUEST, handlePlanApprovalRequest);

return () => {
console.log('🔌 Cleaning up WebSocket connections');
unsubscribeConnection();
unsubscribeStreaming();
unsubscribePlanApproval();
Expand All @@ -468,9 +443,7 @@ const PlanPage: React.FC = () => {
try {

let planResult: ProcessedPlanData | null = null;
console.log("Fetching plan with ID:", planId);
planResult = await PlanDataService.fetchPlanData(planId, useCache);
console.log("Plan data fetched:", planResult);
if (planResult?.plan?.overall_status === PlanStatus.IN_PROGRESS) {
setShowApprovalButtons(true);

Expand Down Expand Up @@ -582,8 +555,6 @@ const PlanPage: React.FC = () => {
plan_id: planData?.plan.id,
m_plan_id: planApprovalRequest?.id || ""
});

console.log("Clarification submitted successfully:", response);
setInput("");
dismissToast(id);
showToast("Clarification submitted successfully", "success");
Expand Down
1 change: 0 additions & 1 deletion src/frontend/src/services/PlanDataService.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ export class PlanDataService {
try {
// Use optimized getPlanById method for better performance
const planBody = await apiService.getPlanById(planId, useCache);
console.log('Raw plan data fetched:', planBody);
return this.processPlanData(planBody);
} catch (error) {
console.log("Failed to fetch plan data:", error);
Expand Down
4 changes: 0 additions & 4 deletions src/frontend/src/services/TeamService.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,12 @@ export class TeamService {
error?: string;
}> {
try {
console.log('Calling /v3/init_team endpoint...');
const response = await apiClient.get('/v3/init_team', {
params: {
team_switched
}
});

console.log('Team initialization response:', response);

return {
success: true,
data: response
Expand Down Expand Up @@ -81,7 +78,6 @@ export class TeamService {
try {
const formData = new FormData();
formData.append('file', teamFile);
console.log(formData);
const response = await apiClient.upload('/v3/upload_team_config', formData);

return {
Expand Down
Loading
Loading