Skip to content

A11y updates #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmarshall merged 5 commits into from
Dec 19, 2024
Merged

A11y updates #742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
348f492
lighter breadcrumb background
danmarshall Dec 19, 2024
e9582d8
use higher contrast hljs stylesheet
danmarshall Dec 19, 2024
b33eb0e
Add role attribute to tree items for improved accessibility
danmarshall Dec 19, 2024
d87a06f
move role=tablist to parent of tabs
danmarshall Dec 19, 2024
d6da902
Add language attribute to HTML tag for improved accessibility
danmarshall Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/_layouts/api.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

{% assign tree_url = site.baseurl | append: "/docs/" | append : tree[0] | append: "/v3/api/" %}

<li class="c-tree__item o-list-bare__item">
<li class="c-tree__item o-list-bare__item" role="treeitem">
<div class="c-tree__toggle js-tree-toggle{% if page_url == tree_url %} is-open is-active{% endif %}">
<a href="{{ tree_url }}" {% if page_url == tree_url %}class="is-active"{% endif %}>
{{ tree[0] }}
Expand Down
2 changes: 1 addition & 1 deletion docs/_layouts/docs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<div class="o-layout__item u-1/4@tablet c-tree-stick">
<ul id="site-tree" class="c-tree o-list-bare" role="tree">
{% for tree in site.data.tree %}
<li class="c-tree__item o-list-bare__item">
<li class="c-tree__item o-list-bare__item" role="treeitem">
<div class="c-tree__toggle js-tree-toggle">
{{ tree[0] }}
</div>
Expand Down
2 changes: 1 addition & 1 deletion docs/_sass/settings/_settings.colors.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1308,7 +1308,7 @@ $ms-gray: (

/// @group Black
/// @type Color
$ms-black-100: #f2f2f2;
$ms-black-100: #f5f5f5;

/// @group Black
/// @type Color
Expand Down
6 changes: 3 additions & 3 deletions docs/app/js/sanddance-app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56437,10 +56437,10 @@ function Sidebar(props) {
}, (0, _base.base).react.createElement("div", {
className: "sidebar-content"
}, (0, _base.base).react.createElement((0, _dataScope.DataScope), Object.assign({}, props.dataScopeProps)), (0, _base.base).react.createElement("div", {
className: "vbuttons",
role: 'tablist'
className: "vbuttons"
}, (0, _base.base).react.createElement("div", {
className: "sidebar-dialogs"
className: "sidebar-dialogs",
role: 'tablist'
}, sidebuttons.map((sidebutton, i)=>(0, _base.base).react.createElement((0, _sideButton.Sidebutton), Object.assign({
key: i
}, props, sidebutton, {
Expand Down
6 changes: 3 additions & 3 deletions docs/dist/sanddance-explorer/v4/sanddance-explorer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47152,10 +47152,10 @@ function $a4defabaac4a9afe$export$1ba59dacbcbf90fe(props) {
}, (0, $a601a4135959dcb0$export$e2253033e6e1df16).react.createElement("div", {
className: "sidebar-content"
}, (0, $a601a4135959dcb0$export$e2253033e6e1df16).react.createElement((0, $86b892255d8eb4f0$export$3fb74a6ae4f1171d), Object.assign({}, props.dataScopeProps)), (0, $a601a4135959dcb0$export$e2253033e6e1df16).react.createElement("div", {
className: "vbuttons",
role: 'tablist'
className: "vbuttons"
}, (0, $a601a4135959dcb0$export$e2253033e6e1df16).react.createElement("div", {
className: "sidebar-dialogs"
className: "sidebar-dialogs",
role: 'tablist'
}, sidebuttons.map((sidebutton, i)=>(0, $a601a4135959dcb0$export$e2253033e6e1df16).react.createElement((0, $d7542c73853af2f5$export$a8fc19311f33df91), Object.assign({
key: i
}, props, sidebutton, {
Expand Down
6 changes: 3 additions & 3 deletions docs/tests/data-inference/v1/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
<!DOCTYPE html>
<html>
<html lang="en">

<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<title>Data-Inference test</title>
<meta name="viewport" content="width=device-width, initial-scale=1">
<script src="https://unpkg.com/vega@^5.30/build/vega.js" charset="utf-8"></script>
<link rel="stylesheet" href="https://unpkg.com/@highlightjs/cdn-assets@11.7.0/styles/default.min.css">
<script src="https://unpkg.com/@highlightjs/cdn-assets@11.7.0/highlight.min.js"></script>
<link rel="stylesheet" href="https://unpkg.com/@highlightjs/cdn-assets@11.11.0/styles/a11y-light.css">
<script src="https://unpkg.com/@highlightjs/cdn-assets@11.11.0/highlight.min.js"></script>
<script src="js/data-inference.js"></script>

<style>
Expand Down
6 changes: 3 additions & 3 deletions docs/tests/v4/es6/js/sanddance-app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56437,10 +56437,10 @@ function Sidebar(props) {
}, (0, _base.base).react.createElement("div", {
className: "sidebar-content"
}, (0, _base.base).react.createElement((0, _dataScope.DataScope), Object.assign({}, props.dataScopeProps)), (0, _base.base).react.createElement("div", {
className: "vbuttons",
role: 'tablist'
className: "vbuttons"
}, (0, _base.base).react.createElement("div", {
className: "sidebar-dialogs"
className: "sidebar-dialogs",
role: 'tablist'
}, sidebuttons.map((sidebutton, i)=>(0, _base.base).react.createElement((0, _sideButton.Sidebutton), Object.assign({
key: i
}, props, sidebutton, {
Expand Down
4 changes: 2 additions & 2 deletions packages/sanddance-explorer/src/controls/sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ export function Sidebar(props: Props) {
<DataScope
{...props.dataScopeProps}
/>
<div className="vbuttons" role='tablist'>
<div className="sidebar-dialogs">
<div className="vbuttons">
<div className="sidebar-dialogs" role='tablist'>
{sidebuttons.map((sidebutton, i) => (
<Sidebutton
key={i}
Expand Down
Loading