Skip to content

M266 (2) #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjcheetham merged 2 commits into from
Nov 17, 2025
Merged

M266 (2) #1882

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf4be0f
Fix std handle forwarding
tyrielv Nov 12, 2025
6cab30f
Merge pull request #1837 from tyrielv/hooks-stdout
tyrielv Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions GVFS/GitHooksLoader/GitHooksLoader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,25 @@ int ExecuteHook(const std::wstring &applicationName, wchar_t *hookName, int argc
PROCESS_INFORMATION pi;
ZeroMemory(&si, sizeof(si));
si.cb = sizeof(si);
si.hStdOutput = GetStdHandle(STD_OUTPUT_HANDLE);
si.hStdError = GetStdHandle(STD_ERROR_HANDLE);
si.dwFlags = STARTF_USESTDHANDLES;
DWORD creationFlags = 0;
HANDLE consoleHandle;

/* If we have a console, use it (ie allow default behavior)*/
if ((consoleHandle = CreateFile(L"CONOUT$", GENERIC_WRITE,
FILE_SHARE_WRITE, NULL, OPEN_EXISTING,
FILE_ATTRIBUTE_NORMAL, NULL)) !=
INVALID_HANDLE_VALUE)
CloseHandle(consoleHandle);
else {
/* Otherwise, forward stdout/err in case they were redirected,
* but do not allow creating a window.*/
si.hStdOutput = GetStdHandle(STD_OUTPUT_HANDLE);
si.hStdError = GetStdHandle(STD_ERROR_HANDLE);
/* Git disallows stdin from hooks */
si.dwFlags = STARTF_USESTDHANDLES;

creationFlags |= CREATE_NO_WINDOW;
}

ZeroMemory(&pi, sizeof(pi));

Expand All @@ -135,7 +151,7 @@ int ExecuteHook(const std::wstring &applicationName, wchar_t *hookName, int argc
NULL, // Process handle not inheritable
NULL, // Thread handle not inheritable
TRUE, // Set handle inheritance to TRUE
CREATE_NO_WINDOW, // Process creation flags
creationFlags , // Process creation flags
NULL, // Use parent's environment block
NULL, // Use parent's starting directory
&si, // Pointer to STARTUPINFO structure
Expand Down
Loading