[fix] failed to save checkpoints in VideoLearner.fit() #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickBue
reviewed
Aug 24, 2020
|
Thanks for making this fix. I would approve, but the PR is made to master. Can you please make a PR to the "staging" branch instead? As per our contribution guidelines we only make code changes to staging, and update master in regular intervals. |
|
@PatrickBue Sure. I just close this PR and open a new one, #613 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix format bug of path string.
Failed to save checkpoints while training the model using
video_learner.fit(save_model=True)Related Issues
None
Checklist:
stagingand notmasterstaging