T shanim/enable multiple queries #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarden95c
reviewed
Aug 22, 2023
src/utils/mashupDocumentParser.ts
Outdated
| return newMetadataArray; | ||
| }; | ||
|
|
||
| const addConnectionOnlyQueryMetadata = (metadataArray: Uint8Array, connectionOnlyQueryNames: string[]) => { |
There was a problem hiding this comment.
nit: the name of the method is Query (one) but you send a list of queries
mabezen
reviewed
Aug 22, 2023
added 7 commits
September 19, 2023 09:47
mabezen
reviewed
Jan 8, 2024
yarden95c
reviewed
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes - workbook + mashup document support for connection-only queries with single loaded query. Contains new API for multiple queries.
Doesn't include - testing & mashup doc validation.