Support usr-merged root filesystems #2485
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DomAyre
force-pushed
the
domayre/usr-merged-fs
branch
from
b27efae to
e0fed7f
Compare
Signed-off-by: Dominic Ayre <dominicayre@microsoft.com>
DomAyre
force-pushed
the
domayre/usr-merged-fs
branch
from
e0fed7f to
105f41d
Compare
helsaawy
requested changes
Nov 26, 2025
| rm -rf rootfs | ||
| mkdir -p rootfs/bin/ | ||
| rm -rf /tmp/base-rootfs && mkdir -p /tmp/base-rootfs | ||
| tar -xf $(BASE) -C /tmp/base-rootfs |
Contributor
There was a problem hiding this comment.
can we just extract the directories we need here, and not the entire filesystem?
Suggested change
| tar -xf $(BASE) -C /tmp/base-rootfs | |
| tar -xf $(BASE) -C /tmp/base-rootfs --no-anchored --no-recursion bin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Some linux distros, such as AzureLinux, are usr-merged meaning that binaries are not where containerplat will expect them to be. This means we need to create symlinks from the usr directory to /bin.
How
When constructing delta.tar.gz, detect if the input rootfs is usr merged, if it isn't, keep the existing behaviour, otherwise create /usr/bin instead of /bin and then symlink.