chore: fix warning about appearance being called off main thread #2716
+15
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
Saadnajmi
reviewed
Oct 8, 2025
Saadnajmi
requested changes
Oct 8, 2025
|
I don't know how to do that :) do you mind taking care of that? |
microsoft-github-policy-service
bot
added
Needs: Attention 👋
I'll give it a shot... |
|
@ospfranco This PR should be superseded by #2729 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Whenever the macOS app starts there is a big amount of output and warnings, at least on the latest macOS version, regarding appearance being fetched not on the main thread. This fixes at least the initial warnings and static calls to getColorScheme by making the work sync on the main thread. Probably incurs in a slight performance penalty but should be minor?
Test Plan:
None :) just start the app and no warnings should pop-up