Sticky nodes prototype #285943
Draft
Sticky nodes prototype #285943
+230
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Code_-_OSS_4UG0zXIQmt.mp4 |
Member
|
Nice! Looking forward to trying this one out and adopting it in the SCM Changes view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prototype for defining nodes to be sticky which are not parent nodes. The code is not fully ready. I implemented two examples for this feature:
SCM Issues: There are difficulties with the SCM input as it updates it's height after initially rendering it. There is no reference to the SCM action button which is why I was not able to easily support it.
Chat Issues: All chat messages are siblings in the tree which causes in a chat session with 5 requests to render all 5 requests above each other instead of only showing the most recent one. Will require an API to specify the max number of nodes that can be sticky which are siblings.
// cc @lszomoru