chore: Added conventional commits spec to CONTRIBUTING.md
#298
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NateD-MSFT
approved these changes
Feb 19, 2025
wmmc88
reviewed
Feb 20, 2025
| * Commit your changes using a descriptive commit message. | ||
| * Push your commit to your forked repository. | ||
| * In GitHub, create a pull request to merge your fork to `main`. | ||
| * Make sure to use the [Conventional Commits](https://www.conventionalcommits.org) specification |
There was a problem hiding this comment.
I wonder if we should enforce this automatically?
There was a problem hiding this comment.
Maybe with https://github.com/marketplace/actions/semantic-pull-request? Not a blocker for this pr but worth considering
There was a problem hiding this comment.
I could do this for this PR - sounds like a pretty easy fix and it's within scope. Will take a bit longer as we should discuss the full set of types that we would like to allow
leon-xd
changed the title
CONTRIBUTING.mdCONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed a bit ago, added a link to the conventional commits spec in the
CONTRIBUTING.mdfile.Also reworded and cleaned up the whole Submitting a Pull Request section.