Skip to content

Conversation

emmanuel-karanja
Copy link
Contributor

Porting of Update-MsIdInvitedUserSponsporsFromInvitedBy for both GA and Beta

Copy link

Learn Build status updates of commit f2fb163:

⚠️ Validation status: warnings

File Status Preview URL Details
module/docs/entra-powershell-beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.md ⚠️Warning View (entra-powershell-beta-preview) Details
module/docs/entra-powershell-v1.0/Users/Update-EntraInvitedUserSponsorsFromInvitedBy.md ⚠️Warning View (entra-powershell-preview) Details
module/Entra/Microsoft.Entra/Reports/Get-EntraCrossTenantAccessActivity.ps1 ✅Succeeded
module/Entra/Microsoft.Entra/Users/Update-EntraInvitedUserSponsorsFromInvitedBy.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Test-EntraBetaCommandPrerequisite.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.ps1 ✅Succeeded
test/Entra/Users/Update-EntraInvitedUserSponsorsFromInvitedBy.Tests.ps1 ✅Succeeded
test/EntraBeta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.Tests..ps1 ✅Succeeded

module/docs/entra-powershell-beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.md

  • Line 119, Column 1: [Warning: file-not-found - See documentation] Invalid file link: 'Update-EntraBetaUser.md'.

module/docs/entra-powershell-v1.0/Users/Update-EntraInvitedUserSponsorsFromInvitedBy.md

  • Line 119, Column 1: [Warning: file-not-found - See documentation] Invalid file link: 'Update-EntraUser.md'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@emmanuel-karanja emmanuel-karanja force-pushed the enganga/Update-EntraInvitedUserSponsorsFromInvitedBy branch from 789ea81 to c9d49d6 Compare February 14, 2025 04:38
Copy link

Learn Build status updates of commit c9d49d6:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.md ✅Succeeded View (entra-powershell-beta-preview)
module/Entra/Microsoft.Entra/Reports/Get-EntraCrossTenantAccessActivity.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Test-EntraBetaCommandPrerequisite.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.ps1 ✅Succeeded
test/EntraBeta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.Tests..ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit af0ab89:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.md ✅Succeeded View (entra-powershell-beta-preview)
module/Entra/Microsoft.Entra/Reports/Get-EntraCrossTenantAccessActivity.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Test-EntraBetaCommandPrerequisite.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.ps1 ✅Succeeded
test/EntraBeta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.Tests..ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit f77f57b:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.md ✅Succeeded View (entra-powershell-beta-preview)
module/Entra/Microsoft.Entra/Reports/Get-EntraCrossTenantAccessActivity.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Test-EntraBetaCommandPrerequisite.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.ps1 ✅Succeeded
test/EntraBeta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.Tests..ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit e616c7e:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.md ✅Succeeded View (entra-powershell-beta-preview)
module/Entra/Microsoft.Entra/Reports/Get-EntraCrossTenantAccessActivity.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Test-EntraBetaCommandPrerequisite.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.ps1 ✅Succeeded
test/EntraBeta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.Tests..ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@KenitoInc KenitoInc force-pushed the enganga/Update-EntraInvitedUserSponsorsFromInvitedBy branch from e616c7e to a6a6587 Compare March 6, 2025 09:58
Copy link

Learn Build status updates of commit a6a6587:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.md ✅Succeeded View (entra-powershell-beta-preview)
module/Entra/Microsoft.Entra/Reports/Get-EntraCrossTenantAccessActivity.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Test-EntraBetaCommandPrerequisite.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.ps1 ✅Succeeded
test/EntraBeta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.Tests..ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit b8db6c5:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.md ✅Succeeded View (entra-powershell-beta-preview)
module/Entra/Microsoft.Entra/Reports/Get-EntraCrossTenantAccessActivity.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Test-EntraBetaCommandPrerequisite.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.ps1 ✅Succeeded
test/EntraBeta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.Tests..ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit d043f9e:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.md ✅Succeeded View (entra-powershell-beta-preview)
module/Entra/Microsoft.Entra/Reports/Get-EntraCrossTenantAccessActivity.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Test-EntraBetaCommandPrerequisite.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.ps1 ✅Succeeded
test/EntraBeta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.Tests..ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

…d' value and hence we don't the inline function. Updated tests
@emmanuel-karanja emmanuel-karanja added the P0 Highest priority label Mar 21, 2025
Copy link

Learn Build status updates of commit 564adae:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.md ✅Succeeded View (entra-powershell-beta-preview)
module/Entra/Microsoft.Entra/Reports/Get-EntraCrossTenantAccessActivity.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Test-EntraBetaCommandPrerequisite.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.ps1 ✅Succeeded
test/EntraBeta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@emmanuel-karanja emmanuel-karanja added the Ready For Review The PR Ready for Review label Mar 21, 2025
Copy link

Learn Build status updates of commit 79e3157:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.md ✅Succeeded View (entra-powershell-beta-preview)
module/EntraBeta/Microsoft.Entra.Beta/Users/Test-EntraBetaCommandPrerequisite.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.ps1 ✅Succeeded
test/EntraBeta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit c624de3:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.md ✅Succeeded View (entra-powershell-beta-preview)
module/EntraBeta/Microsoft.Entra.Beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.ps1 ✅Succeeded
test/EntraBeta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 33627e4:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.md ✅Succeeded View (entra-powershell-beta-preview)
module/EntraBeta/Microsoft.Entra.Beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.ps1 ✅Succeeded
test/EntraBeta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Collaborator

@KenitoInc KenitoInc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design for this cmdlet is messy

  1. Get users and expand sponsors
  2. Use the user id to invoke /users/id/invitedBy

This is duplication. The first request also returns the sponsor, then the second request gets the sponsor using an API request.

This design should be either

  1. Get-EntraUser and select UserId only.
  2. Call /Users/<Id>/sponsors end point to return the sponsors.

or

  1. Get-MgUser with ExpandProperty. Get the value of the sponsors from the response

Note:
For v1.0, endpoint is /Users/<Id>/sponsors
For beta, endpoint can either be /Users/<Id>/sponsors or /Users/<Id>/invitedBy

@KenitoInc
Copy link
Collaborator

Also we could run one API call
/Users?$filter=CreationType eq 'Invitation'&$expand=Sponsors

Then pick the sponsors array and craft a response

Copy link

Learn Build status updates of commit 9c667ee:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.md ✅Succeeded View (entra-powershell-beta-preview)
module/EntraBeta/Microsoft.Entra.Beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.ps1 ✅Succeeded
test/EntraBeta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 2fff099:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.md ✅Succeeded View (entra-powershell-beta-preview)
module/EntraBeta/Microsoft.Entra.Beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.ps1 ✅Succeeded
test/EntraBeta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 7ae84d4:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.md ✅Succeeded View (entra-powershell-beta-preview)
module/EntraBeta/Microsoft.Entra.Beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.ps1 ✅Succeeded
test/EntraBeta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit dd7c32f:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.md ✅Succeeded View (entra-powershell-beta-preview)
module/EntraBeta/Microsoft.Entra.Beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.ps1 ✅Succeeded
test/EntraBeta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit d757cd7:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.md ✅Succeeded View (entra-powershell-beta-preview)
module/EntraBeta/Microsoft.Entra.Beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.ps1 ✅Succeeded
test/EntraBeta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 2220b91:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.md ✅Succeeded View (entra-powershell-beta-preview)
module/EntraBeta/Microsoft.Entra.Beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.ps1 ✅Succeeded
test/EntraBeta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

…hell into enganga/Update-EntraInvitedUserSponsorsFromInvitedBy
Copy link

Learn Build status updates of commit 330a446:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.md ✅Succeeded View (entra-powershell-beta-preview)
module/EntraBeta/Microsoft.Entra.Beta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.ps1 ✅Succeeded
test/EntraBeta/Users/Update-EntraBetaInvitedUserSponsorsFromInvitedBy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@emmanuel-karanja please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Highest priority Ready For Review The PR Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants