Skip to content

Conversation

@marabooy
Copy link
Contributor

Weekly Permissions sync 2025-11-25

@marabooy marabooy requested a review from a team as a code owner November 25, 2025 00:43
Copilot AI review requested due to automatic review settings November 25, 2025 00:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements the weekly permissions synchronization for 2025-11-25, updating permission provisioning configurations and definitions across the Microsoft Graph permissions system.

Key Changes:

  • Enabled Agent Registry permissions (AgentInstance, AgentCollection, AgentCardManifest) by populating previously empty IDs and changing isHidden and isEnabled flags
  • Added new permission definitions for MailboxConfigItem.Read with full pathSet configurations
  • Reorganized Calendar and CloudPC permission path structures for better scheme-specific authorization
  • Extended Policy.Read/WriteConditionalAccess with new claimProviders endpoints

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 18 comments.

File Description
permissions/new/provisioningInfo.json Updated Agent permissions with proper IDs and enabled state; added incomplete AppRegistration and ServicePrincipal.DeleteRestore.All permissions; updated MailboxConfigItem.Read provisioning
permissions/new/permissions.json Added comprehensive Agent Registry permission definitions with pathSets; added MailboxConfigItem.Read definition; reorganized Calendar permission paths by scheme; added claimProviders endpoints to Policy permissions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Comment on lines 1035 to 1088
"AppRegistration.Create": [
{
"id": "",
"scheme": "DelegatedWork",
"environment": "",
"isHidden": true,
"isEnabled": true,
"resourceAppId": "00000003-0000-0000-c000-000000000000"
},
{
"id": "",
"scheme": "Application",
"environment": "",
"isHidden": true,
"isEnabled": true,
"resourceAppId": "00000003-0000-0000-c000-000000000000"
}
],
"AppRegistration.DeleteRestore.All": [
{
"id": "",
"scheme": "DelegatedWork",
"environment": "",
"isHidden": true,
"isEnabled": true,
"resourceAppId": "00000003-0000-0000-c000-000000000000"
},
{
"id": "",
"scheme": "Application",
"environment": "",
"isHidden": true,
"isEnabled": true,
"resourceAppId": "00000003-0000-0000-c000-000000000000"
}
],
"AppRegistration.EnableDisable.All": [
{
"id": "",
"scheme": "DelegatedWork",
"environment": "",
"isHidden": true,
"isEnabled": true,
"resourceAppId": "00000003-0000-0000-c000-000000000000"
},
{
"id": "",
"scheme": "Application",
"environment": "",
"isHidden": true,
"isEnabled": true,
"resourceAppId": "00000003-0000-0000-c000-000000000000"
}
],
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new AppRegistration.Create, AppRegistration.DeleteRestore.All, and AppRegistration.EnableDisable.All permissions added to provisioningInfo.json do not have corresponding definitions in permissions.json. For consistency, permissions should be defined in both files - provisioningInfo.json for provisioning details and permissions.json for API paths, descriptions, and authorization details.

Copilot uses AI. Check for mistakes.
{
"id": "",
"scheme": "DelegatedWork",
"environment": "",
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment field is empty. This field should specify the deployment environment (e.g., "public", "china", "usgov") for the permission to be properly provisioned.

Copilot uses AI. Check for mistakes.
"resourceAppId": "00000003-0000-0000-c000-000000000000"
},
{
"id": "",
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The id field is empty. All permission provisioning entries should have a unique identifier (GUID format) for proper registration and tracking.

Copilot uses AI. Check for mistakes.
],
"ServicePrincipal.DeleteRestore.All": [
{
"id": "",
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The id field is empty. All permission provisioning entries should have a unique identifier (GUID format) for proper registration and tracking.

Copilot uses AI. Check for mistakes.
{
"id": "",
"scheme": "DelegatedWork",
"environment": "",
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment field is empty. This field should specify the deployment environment (e.g., "public", "china", "usgov") for the permission to be properly provisioned.

Copilot uses AI. Check for mistakes.
{
"id": "",
"scheme": "Application",
"environment": "",
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment field is empty. This field should specify the deployment environment (e.g., "public", "china", "usgov") for the permission to be properly provisioned.

Copilot uses AI. Check for mistakes.
],
"AppRegistration.Create": [
{
"id": "",
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The id field is empty. All permission provisioning entries should have a unique identifier (GUID format) for proper registration and tracking.

Copilot uses AI. Check for mistakes.
],
"AppRegistration.DeleteRestore.All": [
{
"id": "",
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The id field is empty. All permission provisioning entries should have a unique identifier (GUID format) for proper registration and tracking.

Copilot uses AI. Check for mistakes.
],
"AppRegistration.EnableDisable.All": [
{
"id": "",
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The id field is empty. All permission provisioning entries should have a unique identifier (GUID format) for proper registration and tracking.

Copilot uses AI. Check for mistakes.
{
"id": "",
"scheme": "DelegatedWork",
"environment": "",
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment field is empty. This field should specify the deployment environment (e.g., "public", "china", "usgov") for the permission to be properly provisioned.

Copilot uses AI. Check for mistakes.
@jasonjoh jasonjoh closed this Dec 1, 2025
@jasonjoh jasonjoh deleted the permissions-update/2025-11-25 branch December 1, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants