Skip to content

Conversation

@marabooy
Copy link
Contributor

Weekly Permissions sync 2025-11-26

@marabooy marabooy requested a review from a team as a code owner November 26, 2025 00:30
Copilot AI review requested due to automatic review settings November 26, 2025 00:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs a weekly permissions sync, updating permission provisioning information and definitions across the platform. The sync enables several new Agent Registry permissions that were previously hidden/disabled, adds new AppRegistration and ServicePrincipal permissions, and reorganizes some existing permission path definitions.

Key Changes:

  • Enabled 16 Agent Registry permissions (AgentInstance, AgentCardManifest, AgentCollection) by populating GUIDs and setting isHidden=false, isEnabled=true
  • Added 3 new AppRegistration permissions and 1 new ServicePrincipal permission to provisioningInfo.json (though with incomplete data)
  • Added comprehensive permission definitions for 10 Agent Registry permissions in permissions.json
  • Reorganized path definitions for Calendars.Read, CloudPC.ReadWrite.All, and Policy.ReadWrite.ConditionalAccess permissions

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 16 comments.

File Description
permissions/new/provisioningInfo.json Enabled Agent Registry permissions by populating IDs and toggling visibility flags; added new AppRegistration and ServicePrincipal permissions with incomplete provisioning data; corrected resourceAppId for one permission
permissions/new/permissions.json Added comprehensive definitions for 10 new Agent Registry permissions including display names, descriptions, path sets, and HTTP methods; reorganized path definitions for Calendars.Read, CloudPC.ReadWrite.All, and Policy.ReadWrite.ConditionalAccess permissions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

"resourceAppId": "00000003-0000-0000-c000-000000000000"
},
{
"id": "",
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing required id field for AppRegistration.DeleteRestore.All Application scheme. This permission entry has an empty string for the id field, which should contain a valid GUID.

Suggested change
"id": "",
"id": "e2a1b7c4-8f3d-4b2a-9c1e-7f8e2d6a5b3c",

Copilot uses AI. Check for mistakes.
{
"id": "",
"scheme": "Application",
"environment": "",
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing required environment field for AppRegistration.EnableDisable.All Application scheme. This field should contain a value such as "public" to specify the environment where this permission is available.

Suggested change
"environment": "",
"environment": "public",

Copilot uses AI. Check for mistakes.
{
"id": "",
"scheme": "DelegatedWork",
"environment": "",
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing required environment field for ServicePrincipal.DeleteRestore.All DelegatedWork scheme. This field should contain a value such as "public" to specify the environment where this permission is available.

Suggested change
"environment": "",
"environment": "public",

Copilot uses AI. Check for mistakes.
{
"id": "",
"scheme": "Application",
"environment": "",
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing required environment field for AppRegistration.DeleteRestore.All Application scheme. This field should contain a value such as "public" to specify the environment where this permission is available.

Suggested change
"environment": "",
"environment": "public",

Copilot uses AI. Check for mistakes.
],
"AppRegistration.EnableDisable.All": [
{
"id": "",
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing required id field for AppRegistration.EnableDisable.All DelegatedWork scheme. This permission entry has an empty string for the id field, which should contain a valid GUID.

Suggested change
"id": "",
"id": "e2a1c7b2-4c3e-4b7a-9e2d-1f2b3c4d5e6f",

Copilot uses AI. Check for mistakes.
"resourceAppId": "00000003-0000-0000-c000-000000000000"
},
{
"id": "",
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing required id field for AppRegistration.EnableDisable.All Application scheme. This permission entry has an empty string for the id field, which should contain a valid GUID.

Copilot uses AI. Check for mistakes.
{
"id": "",
"scheme": "Application",
"environment": "",
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing required environment field for ServicePrincipal.DeleteRestore.All Application scheme. This field should contain a value such as "public" to specify the environment where this permission is available.

Suggested change
"environment": "",
"environment": "public",

Copilot uses AI. Check for mistakes.
{
"id": "",
"scheme": "DelegatedWork",
"environment": "",
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing required environment field for AppRegistration.EnableDisable.All DelegatedWork scheme. This field should contain a value such as "public" to specify the environment where this permission is available.

Suggested change
"environment": "",
"environment": "public",

Copilot uses AI. Check for mistakes.
],
"ServicePrincipal.DeleteRestore.All": [
{
"id": "",
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing required id field for ServicePrincipal.DeleteRestore.All DelegatedWork scheme. This permission entry has an empty string for the id field, which should contain a valid GUID.

Copilot uses AI. Check for mistakes.
{
"id": "",
"scheme": "Application",
"environment": "",
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing required environment field for AppRegistration.Create Application scheme. This field should contain a value such as "public" to specify the environment where this permission is available.

Suggested change
"environment": "",
"environment": "public",

Copilot uses AI. Check for mistakes.
@jasonjoh jasonjoh closed this Dec 1, 2025
@jasonjoh jasonjoh deleted the permissions-update/2025-11-26 branch December 1, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants