Skip to content

Conversation

@marabooy
Copy link
Contributor

Weekly Permissions sync 2025-12-13

@marabooy marabooy requested a review from a team as a code owner December 13, 2025 00:36
Copilot AI review requested due to automatic review settings December 13, 2025 00:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs a weekly permissions synchronization that adds new Copilot package management permissions and updates their provisioning configuration. The changes enable delegated and application-level access to read and manage Copilot packages through the Microsoft Graph API.

  • Adds two new permission scopes: CopilotPackages.Read.All and CopilotPackages.ReadWrite.All
  • Populates previously empty permission IDs and enables visibility for delegated work schemes
  • Configures API paths and HTTP methods for package catalog operations

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
permissions/new/provisioningInfo.json Populates permission IDs for CopilotPackages permissions, enables delegated work schemes (isHidden=false, isEnabled=true), and keeps application schemes hidden/disabled
permissions/new/permissions.json Defines complete permission structures for CopilotPackages.Read.All and CopilotPackages.ReadWrite.All with delegation schemes, API paths (/copilot/admin/catalog/packages), HTTP methods, and ownership information

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"schemes": {
"DelegatedWork": {
"adminDisplayName": "Read all packages information",
"adminDescription": "Allows the user to read the packages information",
Copy link

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistency between adminDescription and userDescription: The admin description says "Allows the user to read the packages information" (singular "user"), but the user description says "Allows the app to read packages information." These descriptions should be consistent in their phrasing. Consider updating the adminDescription to match the pattern used in userDescription, for example: "Allows the app to read the packages information on behalf of the signed-in user."

Copilot uses AI. Check for mistakes.
"schemes": {
"DelegatedWork": {
"adminDisplayName": "Read and update all packages information",
"adminDescription": "Allows the user to read and update the packages information",
Copy link

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistency between adminDescription and userDescription: The admin description says "Allows the user to read and update the packages information" (singular "user"), but the user description says "Allows the app to read and update packages information." These descriptions should be consistent in their phrasing. Consider updating the adminDescription to match the pattern used in userDescription, for example: "Allows the app to read and update the packages information on behalf of the signed-in user."

Copilot uses AI. Check for mistakes.
Comment on lines 10913 to 10916
"methods": [
"GET",
"POST"
],
Copy link

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The permission description mentions "read and update packages information," but the HTTP methods only include GET and POST. Typically, update operations require PATCH or PUT methods (as seen in other similar ReadWrite permissions like AuthenticationContext.ReadWrite.All which includes DELETE, PATCH, and PUT). Consider adding PATCH, PUT, or DELETE to the methods array if package information needs to be updated or deleted, or clarify in the description that only creation (POST) and reading (GET) are supported.

Copilot uses AI. Check for mistakes.
@jasonjoh jasonjoh closed this Dec 15, 2025
@jasonjoh jasonjoh deleted the permissions-update/2025-12-13 branch December 15, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants