-
Notifications
You must be signed in to change notification settings - Fork 464
Update serviceprincipal-removekey.md #9730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Learn Build status updates of commit 72017d2: ✅ Validation status: passed
For more details, please refer to the build report. |
FaithOmbongi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @CCastGit -
Thank you for this contribution.
It feels like this is too much information and not fully within the context of the removeKey API Doc. I suggest we split this into a standalone article, similar to Generate proof-of-possession (PoP) tokens for automating key rolling and certificate updates using Microsoft Graph. Then from the removeKey article, we need only add a note/alert box and point to the new article. What do you think about this?
Also, if you're a Microsoft employee, please ping me on Teams so we can work on this and engage the feature SMEs to approve the new doc.
|
@CCastGit please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
|
Good day Faith,
Thank you for the quick response. I am a Microsoft Employee, my alias is CCast, and I had troubles finding your name in Teams. I would like to connect with you more on this topic, please feel free to ping me on Teams to continue this discussion.
Carlos Castro
Support Escalation Engineer
AAD Authentication
M-F 8 AM to 5 PM Central
Office: +1 (469) 775-3468
***@***.******@***.***>
Technical Backup | Rashad Shahid ***@***.******@***.***>> +1 (469) 775-4840
Technical Backup | Claudiu Sandu ***@***.******@***.***>> +1 (469) 775-0771
Technical Advisor | Mario Cordero Gomez ***@***.******@***.***>> +506 (4) 1161151
Manager | Molly Sysum ***@***.******@***.***>> | +1 (425) 7063079
Premier Support: 1 (800)-936-3100
Azure Support Backup - ***@***.******@***.***>
***@***.***
From: Faith Moraa Ombongi ***@***.***>
Sent: Thursday, December 11, 2025 4:52 AM
To: microsoftgraph/microsoft-graph-docs-contrib ***@***.***>
Cc: Carlos Castro ***@***.***>; Mention ***@***.***>
Subject: Re: [microsoftgraph/microsoft-graph-docs-contrib] Update serviceprincipal-removekey.md (PR #9730)
@FaithOmbongi commented on this pull request.
Hi @CCastGit<https://github.com/CCastGit> -
Thank you for this contribution.
It feels like this is too much information and not fully within the context of the removeKey API Doc. I suggest we split this into a standalone article, similar to Generate proof-of-possession (PoP) tokens for automating key rolling and certificate updates using Microsoft Graph<https://learn.microsoft.com/en-us/graph/application-rollkey-prooftoken?tabs=csharp>. Then from the removeKey article, we need only add a note/alert box and point to the new article. What do you think about this?
Also, if you're a Microsoft employee, please ping me on Teams so we can work on this and engage the feature SMEs to approve the new doc.
-
Reply to this email directly, view it on GitHub<#9730 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BTMMV45VTROHGW26DC4Z4IL4BFEEHAVCNFSM6AAAAACOUJAUGWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKNRWHA2DIMJYGI>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Important
Required for API changes:
Add other supporting information, such as a description of the PR changes:
ADD INFORMATION HERE
Important
The following guidance is for Microsoft employees only. Community contributors can ignore this message; our content team will manage the status.
After you've created your PR, expand this section for tips and additional instructions.
#feedback-addressedto the pull request.For more information, see the Content review process summary.