Skip to content

Conversation

carmen-cruzarana
Copy link

Linked Issue

Closes issue # 559 #559

Proposed change

The changes made allow the CLI to close when pressing X in order to exit the dev CLI.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jayantbh
Copy link
Member

jayantbh commented Oct 3, 2024

Thanks for your contribution, @carmen-cruzarana! :)

There's just one tiny thing left. We'd still need you to sign the CLA.

Additionally, it's a great idea to get confirmation on an issue that you'd like to work on it, and that it's not worked upon by someone else in the community, or by our maintainers to avoid accidental wastage of time or rework. :)

Fortunately in this case no one else was working for it, but it's a good one to keep in mind in the future.

@jayantbh
Copy link
Member

jayantbh commented Oct 3, 2024

It also appears that the linter is failing, so you might want to look into that as well.

Also, just looking at the code I'm unsure how it fixes the bug, if it actually does so.
Could you confirm that you've tested this based on the steps to repro in the issue #559, and that it indeed worked for you?

@jayantbh
Copy link
Member

Hey @carmen-cruzarana, let us know if you still intend to work on this.
I'd be okay with closing the PR in case you're unable, or don't wish to continue on this for any reason.

@jayantbh
Copy link
Member

Closed due to inactivity.

@jayantbh jayantbh closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants