pre-requisite dependency(node or yarn) version check added in dev.sh file

[sahitya-chandra]

fixed #168

1. First check

• Node is installed or not
• Compatible node version is installed or not

2. Second check

• Yarn is installed or not
• Compatible yarn version is installed or not

If these two checks will pass then only ./dev.sh will run successfully

@jayantbh sir take a look

[jayantbh]

This file should also check for the minimum docker versions, since dev.sh requires 3 things to run:

Node, Yarn, and Docker.

Everything else is within the containers.

[jayantbh]

Was this supposed to be version_get?
Or maybe you meant greater-than or equal-to.

IMO naming the function compare_version or version_at_least or something more obvious would be better.

[sahitya-chandra]

I have now changed it to version_at_least

[jayantbh]

I think we're not strict on Node 22.9. It can be anything above 22 (for now).

[jayantbh]

Yarn does need to be 1.22.22 at least.

[jayantbh]

REQUIRED_DOCKER_VERSION=22.3.1

How did you land on this version being required?
Not saying it's wrong, but I thought we need v24 at least. Unless you're sure that it works with v22 perfectly, you might want to change that to v24.

[sahitya-chandra]

REQUIRED_DOCKER_VERSION=22.3.1

How did you land on this version being required? Not saying it's wrong, but I thought we need v24 at least. Unless you're sure that it works with v22 perfectly, you might want to change that to v24.

@jayantbh Sorry sir, I want it to 27.3.1 and this is because I have read docker docs it is the latest docker version and I also use this version locally

should I change it to 27.0.0 or 26 or something

[jayantbh]

The earliest version that supports the docker watch and sync commands will be sufficient.

[jayantbh]

I have an idea that'll make the version check experience better.

Right now, let's say all your versions are wrong...

Then you run dev.sh, and it breaks saying the node version is wrong.
You fix that, then it says yarn version is wrong, and so on.

What if we check all breaking versions without killing the script, and then list breaking versions of everything at the end right before killing the script?

[sahitya-chandra]

@jayantbh Sir, I have changed the docker version 24.0.0 because it is docker watch was added

and can you tell me why my pre-commit checks are failing

[sahitya-chandra]

I have an idea that'll make the version check experience better.

Right now, let's say all your versions are wrong...

Then you run dev.sh, and it breaks saying the node version is wrong. You fix that, then it says yarn version is wrong, and so on.

What if we check all breaking versions without killing the script, and then list breaking versions of everything at the end right before killing the script?

on it sir

[sahitya-chandra]

@jayantbh how my pr has 23 commits. I have not added this much

[jayantbh]

You would need to rebase your branch onto main. This might have happened due to merging main into your branch.

[sahitya-chandra]

@jayantbh Sir i have rebased it but it is still giving this pre-commit check error

[sahitya-chandra]

Is it even possible to fix this error
should I close this pr it is always giving this ore-commit error