Skip to content

Replaced short array syntax usages with traditional array syntax #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aik099 merged 1 commit into from
Jan 20, 2025
Merged

Replaced short array syntax usages with traditional array syntax #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/Selenium2Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ public function mapRemoteFilePath($file): string

public function skipMessage($testCase, $test): ?string
{
$testCallback = [$testCase, $test];
$testCallback = array($testCase, $test);

if ([Html5Test::class, 'testHtml5Types'] === $testCallback) {
if (array(Html5Test::class, 'testHtml5Types') === $testCallback) {
return <<<TEXT
WebDriver does not support setting value in color inputs.

Expand All @@ -80,7 +80,7 @@ public function skipMessage($testCase, $test): ?string
return 'Checking status code is not supported.';
}

if ([JavascriptTest::class, 'testDragDropOntoHiddenItself'] === $testCallback) {
if (array(JavascriptTest::class, 'testDragDropOntoHiddenItself') === $testCallback) {
$browser = $_SERVER['WEB_FIXTURES_BROWSER'] ?? null;

if ($browser === 'firefox' && $this->getSeleniumMajorVersion() === 2) {
Expand All @@ -89,7 +89,7 @@ public function skipMessage($testCase, $test): ?string
}

// Skip right-clicking tests, when an unsupported Selenium version detected.
if (([HoverTest::class, 'testRightClickHover'] === $testCallback || [EventsTest::class, 'testRightClick'] === $testCallback)
if ((array(HoverTest::class, 'testRightClickHover') === $testCallback || array(EventsTest::class, 'testRightClick') === $testCallback)
&& !$this->isRightClickingInSeleniumSupported()
) {
return <<<TEXT
Expand All @@ -100,7 +100,7 @@ public function skipMessage($testCase, $test): ?string
}

// Skips all tests, except mentioned below, for an unsupported Selenium version.
if ([SeleniumSupportTest::class, 'testDriverCannotBeUsedInUnsupportedSelenium'] !== $testCallback
if (array(SeleniumSupportTest::class, 'testDriverCannotBeUsedInUnsupportedSelenium') !== $testCallback
&& !$this->isSeleniumVersionSupported()
) {
return 'Does not apply to unsupported Selenium versions.';
Expand Down
Loading