-
Notifications
You must be signed in to change notification settings - Fork 18
version 1.0 #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mirochaj
wants to merge
664
commits into
main
Choose a base branch
from
v1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
version 1.0 #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…, was forcing mstell bias positive
…rrors in SFR and Mstell
…of lightcone, which then skipped checkpoint
… related to bc03 being read in only in single precision
…e of lookup tables, made emissivity generation lazy so PS doesn't trigger it.
…ter that require more careful treatment
…ation set by pop_mask_logic ('and or 'or')
…being used by bc03 propagating through to SEDs
… PDFs and caused weird problems. just brute-forcing with quad now
…sing. also fixed issue with old approach to IHL not triggering right u(k,m)
…nent solution eventually
…e bug in two tests
…updates needed to account for that and the new convention of providing as argument to any map related routines
…me (WISE, at least) downloads
…ed NFW tabs and the 'tracker'
…optional dependences to pyproject.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents a major change to ARES that breaks backward compatibility, and so will become version 1.0 once accepted. From then on, the goal is to use semantic versioning, keep test coverage near ~100%, and try to keep up with the documentation better than in the past.
There are many big changes, but the ones that will be most noticeable to people already familiar with ARES are:
$HOME/.ares. Previously, we used a subdirectory within the ARES build directory, which often caused problems on clusters, and was awkward for many other reasons.remote.pyscript. For example, to download NIRCAM transmission curves one can simply typeares download nircamfrom anywhere on the command line, and they will be neatly tucked away in$HOME/.ares/nircam.ares.simulations.Simulation, which has methods for common models of interest likeget_21cm_gs(to run global 21-cm signal models), which replaces the previous approach of calling individual objects likeGlobal21cmand then executing therunmethod.Simulationobject without supplying any parameters! The workflow is instead to start from a base set of parameters, likely drawn from aParameterBundle, with modifications applied subsequently.litdata, has been moved toares.data, with the primary functionread. So, to pull in dictionaries of data, one can do something like, e.g.,b15 = ares.data.read('bouwens2015').ares.statichas been renamedares.core.ares.populationsclasses had a__getattr__method that could be used to find and even create non-existent attributes based on the contents of the parameter file. The hope here was to allow anything to be parameterized, and alleviate users and developers from having to implement new functions inares.populationsclasses all the time to accommodate this. Things are more cumbersome now (i.e., there are manyget_<something>routines inares.populationsobjects), but I think much, much clearer.get_<something>, lookup tables are attributes namedtab_<something>, and routines that create big lookup tables are calledgenerate_<something>. You might need to update some call sequences if you access internal methods much, e.g.,LuminosityFunctionis nowget_lf,StellarMassFunctionis nowget_smf, and so on.ares.realizations, for (you guessed it) generating realizations of ARES models. This is extremely preliminary and you'll find no documentation for it. Contact me if you're interested.This PR is not yet ready for review, but I wanted to get the ball rolling and to see how the tests were doing. I'd like to continue updating documentation, tests, and potentially port to PyPi as well. I will keep updating until it is in slightly more respectable shape. In the meantime, if any recent users have some spare cycles and want to check things out, any and all input is totally welcome and much appreciated! @plaplant @gjsun @JudahRockLuberto @JJHibbard. You'll probably want to build the documentation locally in order to see updated examples.