units page fixes #1083
Merged
units page fixes #1083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumaerc
force-pushed
the
cg/units-page-fixes
branch
from
f16e01d to
18b5c8c
Compare
gumaerc
force-pushed
the
cg/units-page-fixes
branch
from
bdf1547 to
0f56e1a
Compare
…he cards are all even height, regardless of the content of other cards in the grid
gumaerc
force-pushed
the
cg/units-page-fixes
branch
from
0f56e1a to
4f2a270
Compare
gumaerc
added
Needs Review
jonkafton
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/4561
Description (What does it do?)
This PR fixes some design issues with the units page noted in the above issue:
whitetolightGray1Cardcomponent so the cards have the hover styles / link behavior that other cards haveScreenshots (if appropriate):
How can this be tested?
mit-openon this branchAdditional Context
The fixes to breadcrumbs were addressed in #1089