KC: Integrate Common Validated Proto Types #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstml
force-pushed
the
compiler/common-types-kind-checker
branch
from
3126f50 to
eca2810
Compare
cstml
force-pushed
the
compiler/common-types-kind-checker
branch
from
eca2810 to
a51fe83
Compare
cstml
force-pushed
the
compiler/common-types-kind-checker
branch
from
a51fe83 to
9a02484
Compare
bladyjoker
approved these changes
Jan 30, 2023
Contributor
bladyjoker
left a comment
bladyjoker
left a comment
There was a problem hiding this comment.
Good stuff, please take a look at and integrate KC into the CLI
Comment on lines
49
to
50
| data KindCheckFailure | ||
| = CheckFailure String |
Contributor
There was a problem hiding this comment.
Let's expose that in the API. Try to think of what errors make sense to expose there and in what granularity.
Comment on lines
+191
to
+193
| -- X To Canonical type conversion functions. | ||
|
|
||
| -- | TyDef to Kind Canonical representation. |
Contributor
There was a problem hiding this comment.
When you have the cycles, having something like https://github.com/mlabs-haskell/lambda-buffers/blob/5d74a0cc1bc1046494b244440d33c52cf4fefa50/lambda-buffers-compiler/src/LambdaBuffers/Compiler/Canonical.hs would be good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapinstead of lists,Textetc.