-
Notifications
You must be signed in to change notification settings - Fork 78
Add the code from PR "Add support for MNE-ICALabel #812" #1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jschepers
wants to merge
20
commits into
mne-tools:main
Choose a base branch
from
jschepers:merge_ic_label
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
2922224
added iclabel code from PR, user input which IC labels to keep, user …
jschepers 3338807
use brain and other as default for icalabel_include
jschepers 4bf3976
added rudimentary plot of excluded components + labels + probabilities
jschepers 8eaf750
Merge remote-tracking branch 'mne-bids-pipeline/ic_label' into merge_…
jschepers 8ca9132
added iclabel code from PR, user input which IC labels to keep, user …
jschepers 5b4d14e
use brain and other as default for icalabel_include
jschepers fd304e1
added rudimentary plot of excluded components + labels + probabilities
jschepers ede148b
Trying to resolve merge conflicts
jschepers 7d2a729
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f1f196f
Merge remote-tracking branch 'upstream/main' into merge_ic_label
larsoner 4a9f10a
BUG: Fixes
larsoner 53d743f
WIP: Fixes
larsoner 0070306
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3e55605
FIX: Comps
larsoner c6bc2a3
Merge remote-tracking branch 'jschepers/merge_ic_label' into merge_ic…
larsoner c2a4b6c
FIX: Need onnx
larsoner ae5bb9d
FIX: Clearer
larsoner ea77558
FIX: Test
larsoner ec5dd1f
FIX: Move
larsoner 1d8e956
Merge branch 'main' into merge_ic_label
larsoner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are really going for broke on this one, we should use the
uniquepydantic workaroundpydantic/pydantic-core#820 (comment)
If you don't want to implement it here maybe add it as a
# TODO:comment in the ICA preprocessing scripts somewhere? (Don't add it in this file as it would make it messier.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think I can really follow you there. Maybe something got lost, but what does "going for broke" mean?
@jschepers I dont actually see where we really select components to be excluded, but in their tutorial it is also quite confusing. I remember we looked at it, but it was some time ago. E.g. in eeglab you specify "remove muscle if probability >80%" and similar. How is this done here, do you remember? Else I will try to give this another spin in debug mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it's just an idiom -- in this case I mean if you want to put forth potentially a lot of effort to try to come up with a more complete/cool solution, you could. What we want here in not just a list with length between 1 and 7 with elements from a set of possible choices, but rather that they are unique elements (i.e., a user shouldn't put in
["eye blink", "eye blink"]). But what you have here is already good enough!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I finally came back to this! Things seem to be working at my end.
FYI some of the components have a kind of low probability... looked like in testing at one point one of the things labeled as
blinkhad a probability of like 0.35 or so. So not sure if you want to add a threshold as suggested by @behinger above. But in the meantime I think this is working as intended, @behinger @jschepers feel free to try it and look etc!