fix: Fix Windows file read issue due to Unix permissions #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you describe the issue a little more fully? |
|
On Windows, calling Dadb.push(File…) throws because the default implementation calls Files.getAttribute(file.toPath(), "unix:mode")to read permissions, and Windows filesystems don’t support the unix:mode attribute view. |
|
Maestro must already be doing some wizardry inside Java-land to solve for this 🤔 |
|
I’m not sure about that—I haven’t used Maestro. I just ran into this issue in my own project and fixed it. I think extending Dadb’s compatibility isn’t a bad idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dadb push fails on Windows because readMode reads file permissions in unix:mode.