Skip to content

Conversation

@samuelhnrq
Copy link
Contributor

PR Checklist

Overview

Removes the last references from the code about --compilers there are still a lot of references in change logs and in documentation but was not sure if those should be removed or not.

@mark-wiemer mark-wiemer added the semver-major implementation requires increase of "major" version number; "breaking changes" label Jul 21, 2025
Copy link
Member

@mark-wiemer mark-wiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but not merging, waiting for Mocha 12 (#5357)

@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: cleanup references of --compilers feat!: cleanup references of --compilers Oct 1, 2025
@mark-wiemer
Copy link
Member

noting maybe we should use chore! instead to emphasize that this isn't a new feature in Mocha really

@JoshuaKGoldberg
Copy link
Member

Technically this does change the user-facing behavior of Mocha. fix!, then? 😄

@mark-wiemer
Copy link
Member

haha it's bikeshedding at this point, feat! is fine by me

Copy link
Member

@mark-wiemer mark-wiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are now failing

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author waiting on response from OP or other posters - more information needed label Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-major implementation requires increase of "major" version number; "breaking changes" status: waiting for author waiting on response from OP or other posters - more information needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚀 Feature: Remove the long-deprecated --compilers option

3 participants