mcp: update to jsonschema that does not validate structs #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to the latest jsonschema commit, which removes the ability to validate structs.
|
Do we need to update |
|
Yes indeed. Added a test. |
findleyr
reviewed
Sep 22, 2025
examples/server/toolschemas/main.go
Outdated
| return errf("failed to unmarshal arguments: %v", err), nil | ||
| } | ||
| if err := t.inputSchema.Validate(input); err != nil { | ||
| if err := validateStruct(input, t.inputSchema); err != nil { |
There was a problem hiding this comment.
This isn't right: once we re-marshal, we're no longer validating the original JSON.
For example, suppose the input contains "foo": 0, and the struct has omitempty for the Foo field, and "foo" is required. Then the original input is valid, but the re-marshalled input is not.
This is why we should expose helpers for this...
findleyr
approved these changes
Sep 22, 2025
| } | ||
|
|
||
| // unmarshalAndValidate unmarshals data to a map[string]any, then validates that against res. | ||
| func unmarshalAndValidate(data []byte, res *jsonschema.Resolved) error { |
There was a problem hiding this comment.
Don't you need to ApplyDefaults also? Not necessarily for this CL.
There was a problem hiding this comment.
That wasn't in the original, so I didn't add it.
But yes, that seems right. Will do a followup (possibly tomorrow).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the latest jsonschema commit, which removes the ability to validate structs and changes the type of ForOptions.TypeSchemas.