Skip to content

Replace Instant with String for lastModified in Annotations #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2025
Merged

Replace Instant with String for lastModified in Annotations #383

merged 1 commit into from
Nov 10, 2025
+20 −13

Conversation

@kpavlov
Copy link
Contributor

@kpavlov kpavlov commented Nov 10, 2025

Replace Instant with String for lastModified in Annotations

Motivation and Context

To fix serialization/kotlin library version conflicts

How Has This Been Tested?

Unit test

Breaking Changes

Yes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@kpavlov kpavlov marked this pull request as ready for review November 10, 2025 15:52
@kpavlov kpavlov requested a review from devcrocod November 10, 2025 15:52
@kpavlov kpavlov added the bugfix Something was fixed 🎉 label Nov 10, 2025
devcrocod
devcrocod approved these changes Nov 10, 2025
View reviewed changes
Copy link
Contributor

@devcrocod devcrocod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kpavlov kpavlov merged commit e6432db into main Nov 10, 2025
4 checks passed
@kpavlov kpavlov deleted the kpavlov/use-string-for-instant-serde branch November 10, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devcrocod devcrocod devcrocod approved these changes

Assignees

No one assigned

Labels

bugfix Something was fixed 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kpavlov @devcrocod