Skip to content

Conversation

@Adebayo120
Copy link
Contributor

While trying to integrate logging with ServerCapabilities, I discovered that we have two methods and private properties on the Builder class that store ServerCapabilities. This PR removes the duplicate, so we maintain just one interface for setting ServerCapabilities

Motivation and Context

How Has This Been Tested?

Yes

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@Adebayo120 Adebayo120 changed the title Removed redundant Builder.setServerCapabilities method Removed redundant Builder.setServerCapabilities duplicate method Oct 12, 2025
@CodeWithKyrian
Copy link
Contributor

Please sign your commits before we can merge

@Adebayo120 Adebayo120 force-pushed the remove-redundant-set-capability-builder-method branch from abf2d20 to fa63cf6 Compare October 12, 2025 12:47
@Adebayo120
Copy link
Contributor Author

Please sign your commits before we can merge

Done @CodeWithKyrian

@CodeWithKyrian CodeWithKyrian merged commit 4486776 into modelcontextprotocol:main Oct 12, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants