[Server] Make CORS headers configurable in StreamableHttpTransport #118
+59
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for jumping on that @CodeWithKyrian 👍 @soyuka does that solve the issue for you? |
soyuka
reviewed
Oct 25, 2025
soyuka
reviewed
Oct 26, 2025
| private readonly ResponseFactoryInterface $responseFactory, | ||
| private readonly StreamFactoryInterface $streamFactory, | ||
| array $corsHeaders = [], | ||
| private readonly LoggerInterface $logger = new NullLogger(), |
There was a problem hiding this comment.
any reason you don't set corsHeaders at the end to avoid breaking current implementations?
There was a problem hiding this comment.
Yeah, wanted to keep things consistent with how the logger is passed across the SDK ie it’s always the last argument, and I think that consistency makes things more predictable overall. Since we haven’t tagged a release yet, this kind of breaking change is still fair game (for now).
There was a problem hiding this comment.
yup agree, we'd need to tag soon and care more than tho
CodeWithKyrian
force-pushed
the
feat/make-cors-headers-configurable
branch
from
e115158 to
78d1509
Compare
chr-hertel
added a commit
to symfony/ai
that referenced
this pull request
Oct 27, 2025
…ertel) This PR was merged into the main branch. Discussion ---------- [MCP Bundle] Fix transport arguments of McpController | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Docs? | no | Issues | | License | MIT Follows modelcontextprotocol/php-sdk#118 Commits ------- ee141ea Fix transport arguments of McpController
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to configure CORS headers in
StreamableHttpTransport, addressing the opinionated and inflexible header implementation that was previously hardcoded.Motivation and Context
The current CORS implementation was explicitly set with fixed headers, limiting flexibility for different deployment scenarios. As raised in #112, this approach hid security settings and provided no way to adapt them when using reverse proxies like nginx or when specific CORS policies are required.
What's Changed
corsHeadersparameter toStreamableHttpTransportconstructorBreaking Changes
Minor: The logger parameter has shifted one position in the constructor signature.
If you’re passing it positionally, you’ll now need to include the new corsHeaders array parameter before it. Named arguments or cases where logger is omitted remain unaffected.
This change aligns the parameter order with how logger is handled consistently across the SDK.