Fix pyright error and replace wildcard import with explicit imports #1532
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses issues introduced in PR #1247: 1. Fixed pyright reportMissingTypeStubs error by adding __init__.py to the extensions directory, making it a proper Python package 2. Replaced wildcard import in auth/__init__.py with explicit imports as requested in code review The changes ensure type checking passes and maintain backward compatibility with existing code that imports from mcp.client.auth.
pcarleton
approved these changes
Oct 29, 2025
felixweinberger
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues introduced in PR #1247 that caused CI failures and addresses a code review comment.
Motivation and Context
PR #1247 introduced a new
mcp.client.auth.extensions.client_credentialsmodule but did not include an__init__.pyfile in theextensionsdirectory, causing pyright to fail with areportMissingTypeStubserror. Additionally, a code review comment from @Kludex requested replacing the wildcard import inauth/__init__.pywith explicit imports.How Has This Been Tested?
mcp.client.authstill work correctlyBreaking Changes
None. This maintains full backward compatibility with existing code.
Types of changes
Checklist
Additional context
Changes made:
src/mcp/client/auth/extensions/__init__.pyto make the extensions directory a proper Python packagesrc/mcp/client/auth/__init__.pywith explicit imports of all public APIs:__all__declaration for clear public API definitionFixes the CI failure in PR #1247.