Skip to content

Conversation

@dogacancolak
Copy link
Contributor

@dogacancolak dogacancolak commented Oct 31, 2025

Motivation and Context

As raised in #1495, one of the changes in #1324 included raising an error if PRM endpoint request failed. This caused backwards compatibility issues with MCP servers that haven't yet added support for PRM

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@maxisbey maxisbey added needs more eyes auth Issues and PRs related to Authentication / OAuth P1 Significant bug affecting many users, highly requested feature labels Nov 4, 2025
Copy link
Contributor

@maxisbey maxisbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you please add a unit test for this which would fail before the fix and pass with your changes

@dogacancolak
Copy link
Contributor Author

Thanks for the PR! Could you please add a unit test for this which would fail before the fix and pass with your changes

@maxisbey Thanks for the feedback! I added a unit test that closely mimics another test named test_oauth_discovery_fallback_conditions (right above the one I added). I have confirmed that the new unit test fails without the change in the PR, and succeeds with the change.

@dogacancolak
Copy link
Contributor Author

Hi @maxisbey, seems like you've made some extensive changes that also cover this bug. I can fix the PR checks if you think this unit test will be useful. Otherwise we can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auth Issues and PRs related to Authentication / OAuth P1 Significant bug affecting many users, highly requested feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants