Fix the entity search by reversing includes call #2808
+47
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olaservo
added
server-sequentialthinking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In main, entity search was broken, the "includes" call on line 151 should have called the method on the query with the argument of the entityName, not the reverse
From the javascript docs:
Server Details
Motivation and Context
bugfix
How Has This Been Tested?
Yes, tested on Claude Desktop only. "what do you know about elmo", fix is only
Breaking Changes
No, just fixes the "search_nodes" tool call
Types of changes
Checklist
Additional context
Just a bug fix