Skip to content

Conversation

@phormio
Copy link
Contributor

@phormio phormio commented May 22, 2025

I've corrected spelling, grammar, and some usage. (I should probably say that I'm a native speaker of English.)

I've changed all occurrences of "regardless if" to "regardless of whether". There may be English speakers who would accept "regardless if", but it sounds very strange to my ears.

@michaliskambi
Copy link
Collaborator

Thank you, I appreciate English corrections very much -- I'm not a native English speaker, so I likely made some phrases that sound weird.

I will review and apply over the weekend, I may want to tweak some things. (and if you can then review my corrections, I will appreciate it :) )

@phormio
Copy link
Contributor Author

phormio commented May 22, 2025

I'd be happy to review any adjustments you make to this PR.

@michaliskambi michaliskambi merged commit 8da9bd5 into modern-pascal:master May 25, 2025
2 checks passed
@michaliskambi
Copy link
Collaborator

I committed small changes on top and merged. The version on https://castle-engine.io/modern_pascal is already updated to reflect the improvements. Thank you again!

Feel welcome to correct after me (see my commit 3a49511 ), simply create new PR :) In particular I remade the paragraph about "memory being zeroed" to say more explicitly what I intended:

A helpful property we can use to write robust destructors (that can handle half-created instances) is that the memory of the class is guaranteed to be zeroed right before the constructor code is executed. So we know that at the beginning, all class references are nil, all integers are 0 and so on. The strategy for writing a robust destructor is thus: "be prepared that any field may still be zero, and handle it without errors".

@phormio phormio deleted the correct-english-1 branch May 25, 2025 04:10
@phormio
Copy link
Contributor Author

phormio commented May 25, 2025

I read 3a49511 and would make one small change: I would change "code" to "the code" in:

In effect, code below works without any memory leaks, even though constructor execution is interrupted

(Sorry, this is too trivial for a new PR.)

@michaliskambi
Copy link
Collaborator

I read 3a49511 and would make one small change: I would change "code" to "the code" in:
In effect, code below works without any memory leaks, even though constructor execution is interrupted
(Sorry, this is too trivial for a new PR.)

Thanks, done! ( d1212c9 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants