Fix Discover URL filter parsing, improve search sidebar #5104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes category filters like
/discover/plugins?g=categories:velocityby correctly reading query params when multiple filter groups share the same query key (e.g. "g"). Previously we only matched the first g filter type, so valid values (like plugin platform/category) wouldn’t resolve and the UI wouldn’t show the filter as selected.Also makes discover sidebar tag icons/names use the same nice colors as project pages (platform/category tags) and localizes the remaining user-facing strings in the discover filter UI.